Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google/go-containerregistry/pkg/authn/k8schain #2252

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 4, 2024

What this PR does / why we need it:

I upgraded google/go-containerregistry/pkg/authn/k8schain to avoid the following error with go get:

$ go get
go: github.com/google/go-containerregistry/pkg/authn/[email protected] requires
        github.com/google/[email protected] requires
        github.com/containerd/[email protected] requires
        github.com/Microsoft/[email protected] requires
        github.com/containerd/[email protected] requires
        github.com/Microsoft/[email protected] requires
        github.com/containerd/[email protected] requires
        github.com/Microsoft/hcsshim/[email protected] requires
        github.com/docker/[email protected] requires
        github.com/mitchellh/[email protected]: invalid version: git ls-remote -q origin in /Users/tenzen/go/pkg/mod/cache/vcs/94ed57c5b21c953d93b47487113db43a5c9b69fd990329ec70dc77348c4dd443: exit status 128:
        remote: Repository not found.
        fatal: repository 'https://github.com/mitchellh/osext/' not found

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 4, 2024

/assign @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 4, 2024

/remove-kind bug
/kind cleanup

@google-oss-prow google-oss-prow bot removed the kind/bug label Jan 4, 2024
Copy link

@tenzen-y: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

/remove-kind bug
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member Author

@andreyvelich @johnugeorge friendly ping :)

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review @tenzen-y and thanks for the fix
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 16, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

@tenzen-y For some reason I can't re-run the failed action. Please can you push your commit once again ?

@tenzen-y
Copy link
Member Author

@tenzen-y For some reason I can't re-run the failed action. Please can you push your commit once again ?

Oh, I see. I pushed the commit once more.

@tenzen-y
Copy link
Member Author

All E2Es with mxnet failed. I guess that our e2e with mxnet is broken. Let me investigate.

@tenzen-y
Copy link
Member Author

All E2Es with mxnet failed. I guess that our e2e with mxnet is broken. Let me investigate.

All PRs are blocked by #2261

@tenzen-y tenzen-y mentioned this pull request Mar 4, 2024
1 task
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 4, 2024

@andreyvelich @johnugeorge Hi, could we merge this PR since this PR would resolve the dependency errors?
Also, could we re-start Go Test / Unit Test (1.27.1) (pull_request) failed by flakiness?

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 5, 2024
@google-oss-prow google-oss-prow bot merged commit 03a4001 into kubeflow:master Mar 5, 2024
59 checks passed
@tenzen-y tenzen-y deleted the upgrade-k8schain branch March 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants