-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade google/go-containerregistry/pkg/authn/k8schain #2252
Conversation
/assign @andreyvelich @johnugeorge |
/remove-kind bug |
@tenzen-y: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andreyvelich @johnugeorge friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review @tenzen-y and thanks for the fix
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tenzen-y For some reason I can't re-run the failed action. Please can you push your commit once again ? |
8fcdde1
to
d7c29e1
Compare
Oh, I see. I pushed the commit once more. |
d7c29e1
to
f801f2c
Compare
All E2Es with mxnet failed. I guess that our e2e with mxnet is broken. Let me investigate. |
All PRs are blocked by #2261 |
Signed-off-by: tenzen-y <[email protected]> Signed-off-by: Yuki Iwai <[email protected]>
f801f2c
to
dfc5ca4
Compare
@andreyvelich @johnugeorge Hi, could we merge this PR since this PR would resolve the dependency errors? |
/lgtm |
What this PR does / why we need it:
I upgraded
google/go-containerregistry/pkg/authn/k8schain
to avoid the following error withgo get
:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: