Skip to content

Commit

Permalink
[SDK] Use Katib SDK for E2E Tests (#2075)
Browse files Browse the repository at this point in the history
* [SDK] Use Katib SDK for E2E tests

* Fix pvc deletion

* Add list_suggestions API

* Remove wait from edit Experiment function

* Add shell to GitHub action

* Add protobuf package to Katib SDK

* Add Experiment Timeout to 40 min

* Modify SDK Examples

* Fix example text

* Change to custom_api

* Enable verbose logging for Katib E2E

* Use expected condition arg

* Add timeout and delete options

* Modify logging to debug

* Use read API to check resource status
  • Loading branch information
andreyvelich authored Jan 16, 2023
1 parent ae68b77 commit 6bcbd25
Show file tree
Hide file tree
Showing 13 changed files with 1,406 additions and 1,169 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/template-e2e-test/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ inputs:
training-operator:
required: false
description: whether to deploy training-operator or not
default: "false"
default: false
trial-images:
required: true
description: comma delimited trial image name
katib-ui:
required: true
description: whether to deploy katib-ui or not
default: "false"
description: whether to deploy katib-ui or not
default: false
database-type:
required: false
description: mysql or postgres
Expand All @@ -25,11 +25,11 @@ inputs:
runs:
using: composite
steps:
- name: Set Up Minikube Cluster
- name: Setup Minikube Cluster
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh ${{ inputs.katib-ui }} ${{ inputs.trial-images }} ${{ inputs.experiments }}

- name: Set Up Katib
- name: Setup Katib
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-katib.sh ${{ inputs.katib-ui }} ${{ inputs.training-operator }} ${{ inputs.database-type }}

Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/template-setup-e2e-test/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,23 @@ inputs:
runs:
using: composite
steps:
- name: Set Up Minikube Cluster
- name: Setup Minikube Cluster
uses: manusa/[email protected]
with:
minikube version: 'v1.28.0'
minikube version: v1.28.0
kubernetes version: ${{ inputs.kubernetes-version }}
start args: --wait-timeout=60s
driver: 'none'
driver: none
github token: ${{ env.GITHUB_TOKEN }}

- name: Set Up Docker Buildx
- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Set Up Go env
uses: actions/setup-go@v3
- name: Setup Python
uses: actions/setup-python@v4
with:
go-version-file: go.mod
python-version: 3.9

- name: Install Katib SDK
shell: bash
run: pip install -e sdk/python/v1beta1
Loading

0 comments on commit 6bcbd25

Please sign in to comment.