fix(ui): update None Collector with Push Collector. (#2418)

* fix(ui): update None Collector with Push Collector. Signed-off-by: Electronic-Waste <[email protected]> * fix(ui): replace some remaining None MC. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
kubeflow · Dec 4, 2024 · 3363964 · 3363964
1 parent 5212949
commit 3363964
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/pkg/ui/v1beta1/frontend/src/app/enumerations/metrics-collector.ts b/pkg/ui/v1beta1/frontend/src/app/enumerations/metrics-collector.ts
@@ -4,5 +4,5 @@ export enum CollectorKind {
   TFEVENT = 'TensorFlowEvent',
   PROMETHEUS = 'PrometheusMetric',
   CUSTOM = 'Custom',
-  NONE = 'None',
+  PUSH = 'Push',
 }
diff --git a/pkg/ui/v1beta1/frontend/src/app/models/experiment.k8s.model.ts b/pkg/ui/v1beta1/frontend/src/app/models/experiment.k8s.model.ts
@@ -110,7 +110,7 @@ export type CollectorKind =
   | 'TensorFlowEvent'
   | 'PrometheusMetric'
   | 'Custom'
-  | 'None';
+  | 'Push';
 
 export interface HttpGet {
   host?: string;

diff --git a/pkg/ui/v1beta1/frontend/src/app/models/trial.k8s.model.ts b/pkg/ui/v1beta1/frontend/src/app/models/trial.k8s.model.ts
@@ -37,7 +37,7 @@ export type CollectorKind =
   | 'TensorFlowEvent'
   | 'PrometheusMetric'
   | 'Custom'
-  | 'None';
+  | 'Push';
 
 export interface Objective {
   type: ObjectiveType;

diff --git a/...tend/src/app/pages/experiment-creation/metrics-collector/metrics-collector.component.html b/...tend/src/app/pages/experiment-creation/metrics-collector/metrics-collector.component.html
@@ -9,7 +9,7 @@
           <mat-option [value]="kind.TFEVENT">TensorFlow Event</mat-option>
           <mat-option [value]="kind.PROMETHEUS">Prometheus</mat-option>
           <mat-option [value]="kind.CUSTOM">Custom</mat-option>
-          <mat-option [value]="kind.NONE">None</mat-option>
+          <mat-option [value]="kind.PUSH">Push</mat-option>
         </mat-select>
       </mat-form-field>
 

diff --git a/pkg/ui/v1beta1/frontend/src/app/services/experiment-form.service.ts b/pkg/ui/v1beta1/frontend/src/app/services/experiment-form.service.ts
@@ -360,7 +360,7 @@ export class ExperimentFormService {
       collector: { kind },
     };
 
-    if (kind === 'StdOut' || kind === 'None') {
+    if (kind === 'StdOut' || kind === 'Push') {
       delete metrics.source;
       return metrics;
     }