Skip to content

Commit

Permalink
Upgrade helm to 2.14.1, fix chart issue (#288)
Browse files Browse the repository at this point in the history
* Upgrade helm to 2.14.1, fix #24395930

* Upgrade helm to 2.14.1, fix #24395930

* Upgrade helm to 2.14.1, fix #24395930
  • Loading branch information
cheyang authored Jan 9, 2020
1 parent 2ae9c35 commit b96e1ac
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

ARG GOLANG_VERSION=1.10
ARG KUBE_VERSION=v1.11.2
ARG HELM_VERSION=v2.9.1
ARG HELM_VERSION=v2.14.1
ARG VERSION=v0.3.0-rc
ARG OS_ARCH=linux-amd64
ARG COMMIT=stable
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.install
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ COPY . .

RUN make

RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.9.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.9.1-linux-amd64.tar.gz && \
RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.14.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.14.1-linux-amd64.tar.gz && \
mv linux-amd64/helm /usr/local/bin/helm && \
chmod u+x /usr/local/bin/helm

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.notebook.cpu
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ COPY . .

RUN make

RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.9.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.9.1-linux-amd64.tar.gz && \
RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.14.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.14.1-linux-amd64.tar.gz && \
mv linux-amd64/helm /usr/local/bin/helm && \
chmod u+x /usr/local/bin/helm

Expand All @@ -24,7 +24,7 @@ FROM $BASE_IMAGE

COPY --from=build /go/src/github.com/kubeflow/arena/bin/arena /usr/local/bin/arena

COPY --from=build /usr/local/bin/helm /usr/local/bin/helm
COPY --from=build /usr/local/bin/helm /usr/local/bin/arena-helm

COPY --from=build /go/src/github.com/kubeflow/arena/charts /charts

Expand Down
6 changes: 3 additions & 3 deletions Dockerfile.notebook.kubeflow
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ COPY . .

RUN make

RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.9.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.9.1-linux-amd64.tar.gz && \
RUN wget https://storage.googleapis.com/kubernetes-helm/helm-v2.14.1-linux-amd64.tar.gz && \
tar -xvf helm-v2.14.1-linux-amd64.tar.gz && \
mv linux-amd64/helm /usr/local/bin/helm && \
chmod u+x /usr/local/bin/helm

Expand All @@ -23,7 +23,7 @@ FROM $BASE_IMAGE

COPY --from=build /go/src/github.com/kubeflow/arena/bin/arena /usr/local/bin/arena

COPY --from=build /usr/local/bin/helm /usr/local/bin/helm
COPY --from=build /usr/local/bin/helm /usr/local/bin/arena-helm

COPY --from=build /go/src/github.com/kubeflow/arena/charts /charts

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ notebook-image:
build-pkg:
docker rm -f arena-pkg || true
docker build --build-arg "KUBE_VERSION=v1.11.2" \
--build-arg "HELM_VERSION=v2.9.1" \
--build-arg "HELM_VERSION=v2.14.1" \
--build-arg "COMMIT=${GIT_SHORT_COMMIT}" \
--build-arg "VERSION=${VERSION}" \
--build-arg "OS_ARCH=${OS_ARCH}" \
Expand Down

0 comments on commit b96e1ac

Please sign in to comment.