-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keadm offline installation #639
base: master
Are you sure you want to change the base?
add keadm offline installation #639
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
related kubeedge/kubeedge#5852 |
91a98cf
to
8ad5cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember if it needed a kubeedge/pause
image, and I found out via the keadm config images list
that it needed a kubeedge/admission
image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the code, I found that kubeedge/admission
is a KubeEdge image, but it is not installed by keadm.
the kubeedge/admission
can only be installed manually by https://github.com/kubeedge/kubeedge/tree/master/build/admission
I add a issue for the problem kubeedge/kubeedge#5904
the doc is about the keadm function. At this moment, kubeedge/admission
, which cannot be installed by keadm , can be omitted from the documentation.However, I will also modify the document to explain the situation with kubeedge/admission.
As for the issue with kubeedge/pause, I will respond after completing my research.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piwriw the puase image for join operation isn't what must do, based on kubeedge/kubeedge#5309.
Only when the user modifies the configuration parameters of containerd, the keadm join require a pause image.
@magichan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8ad5cea
to
d361a7a
Compare
d361a7a
to
1398610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR still in working progress? Seemd DCO need to be fixed and also need to rebase the code.
Which issue(s) this PR fixes:
Fixes #
feature
keadm add offline install doc.
update keadm install chinese part and add offline install
no
two commit , one for updating keadm install chinese part, one for adding offline install doc.