Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keadm offline installation #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magichan
Copy link
Contributor

@magichan magichan commented Sep 14, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the current behavior? (You can also link to an open issue here)

keadm add offline install doc.

  • What is the new behavior (if this is a feature change)?

update keadm install chinese part and add offline install

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

two commit , one for updating keadm install chinese part, one for adding offline install doc.

@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2024
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024
@magichan
Copy link
Contributor Author

related kubeedge/kubeedge#5852

@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@magichan magichan force-pushed the install_kubeedge_offline_by_keadm branch 2 times, most recently from 91a98cf to 8ad5cea Compare September 25, 2024 14:33
@magichan magichan changed the title WIP add offline install WIP: update keadm install chinese part add offline install Sep 25, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember if it needed a kubeedge/pause image, and I found out via the keadm config images list that it needed a kubeedge/admission image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piwriw

After reviewing the code, I found that kubeedge/admission is a KubeEdge image, but it is not installed by keadm.

the kubeedge/admission can only be installed manually by https://github.com/kubeedge/kubeedge/tree/master/build/admission

I add a issue for the problem kubeedge/kubeedge#5904

the doc is about the keadm function. At this moment, kubeedge/admission, which cannot be installed by keadm , can be omitted from the documentation.However, I will also modify the document to explain the situation with kubeedge/admission.

As for the issue with kubeedge/pause, I will respond after completing my research.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piwriw the puase image for join operation isn't what must do, based on kubeedge/kubeedge#5309.

Only when the user modifies the configuration parameters of containerd, the keadm join require a pause image.

@kubeedge-bot
Copy link
Collaborator

@magichan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2024
@magichan magichan force-pushed the install_kubeedge_offline_by_keadm branch from 8ad5cea to d361a7a Compare October 17, 2024 12:48
@magichan magichan force-pushed the install_kubeedge_offline_by_keadm branch from d361a7a to 1398610 Compare October 17, 2024 12:51
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2024
@magichan magichan changed the title WIP: update keadm install chinese part add offline install add keadm offline installation Oct 17, 2024
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still in working progress? Seemd DCO need to be fixed and also need to rebase the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants