Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: We need to fix some links for local development #567

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

1Shubham7
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the new behavior (if this is a feature change)?

during local development when you click "documentation" it takes you to "https://kubeedge.io/docs/" rather than "localhost:3000/docs" . I have fixed that.

Fixes #566

Works towards solving #533

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
@1Shubham7
Copy link
Contributor Author

@fisherxu @Shelley-BaoYue I would suggest we should call it "latest" rather than "next". what do you say?

@Shelley-BaoYue
Copy link
Collaborator

@fisherxu @Shelley-BaoYue I would suggest we should call it "latest" rather than "next". what do you say?

I think "latest" is not appropriate here. "Latest" could be misleading and imply that this is the most recently released version. In reality, what we want to convey is that this is the upcoming version - the one that is currently in development and has not yet been officially released.

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@kubeedge-bot kubeedge-bot merged commit a1d0952 into kubeedge:master Jun 5, 2024
6 checks passed
@1Shubham7 1Shubham7 deleted the fixing-dev-env branch December 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: We need to fix some links for local development
4 participants