add link at Supporters redirect to the instructions doc. #482
Conversation
kubeedge-bot
added
the
size/S
Shelley-BaoYue
force-pushed
the
supporters
branch
3 times, most recently
from
94ae28f to
c0e4392
Compare
kubeedge-bot
added
size/M
| }, | ||
| "item.label.Next": { | ||
| "message": "Next", | ||
| "description": "Navbar item with label Next" | ||
| }, | ||
| "item.label.v1.15": { | ||
| "message": "v1.15", | ||
| "description": "Navbar item with label v1.15" |
There was a problem hiding this comment.
Another question, what's meaning of labels above? And what's the effect without them?
There was a problem hiding this comment.
Another question, what's meaning of labels above? And what's the effect without them?
Auto generated Chinese version of the label name using yarn write-translations. Actually, when we do any changes on the pages, we need to using yarn write-translations --locale zh to generate the corresponding Chinese version and translate it.
For example, if I change the "message" content to "1.15 版本" now, it would be displayed in Chinese as follows.
There was a problem hiding this comment.
Ok, sounds good, if it's auto generated, how about adding a check in CI?
There was a problem hiding this comment.
Ok, sounds good, if it's auto generated, how about adding a check in CI?
Maybe it's worth to add this CI to check the Chinese version. I will create a issue to track.
There was a problem hiding this comment.
Okey. Let's open an issue to track it.
There was a problem hiding this comment.
Okey. Let's open an issue to track it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Signed-off-by: Shelley-BaoYue <[email protected]>
Signed-off-by: Shelley-BaoYue <[email protected]>
Shelley-BaoYue
force-pushed
the
supporters
branch
from
9b1c18b to
985a535
Compare
|
Made a small optimization, the whole title of "Join the growing community" can support link redirection. PTAL @fisherxu @kevin-wangzefeng |
Shelley-BaoYue
force-pushed
the
supporters
branch
from
985a535 to
0f37656
Compare
Signed-off-by: Shelley-BaoYue <[email protected]>
Shelley-BaoYue
force-pushed
the
supporters
branch
from
0f37656 to
fd444fe
Compare
add link at Supporters redirect to the instructions doc. Signed-off-by: Shelley-BaoYue <[email protected]>
feature
Add a link at Supporters to help users to get "how to add logo at supporters"
#470