Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL for Supporters section in home page #416

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Add URL for Supporters section in home page #416

merged 4 commits into from
Aug 24, 2023

Conversation

coder12git
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@coder12git
fixed supporters link
d640de3 
Signed-off-by: Suruchi Kumari <[email protected]>
@coder12git coder12git changed the title Add URL pporters section in home page Add URL Supporters section in home page Aug 22, 2023
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2023
@coder12git coder12git changed the title Add URL Supporters section in home page Add URL for Supporters section in home page Aug 22, 2023
@coder12git
Copy link
Contributor Author

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes / features)

  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Issue -> Add url https://kubeedge.io/supporters for Supporters section in home page #415

  • Other information:
    In .docusaurus/ routes file I have added this code -
    {
    path: "/supporters",
    component: Supporters,
    exact: true,
    },

Loom.Message.-.22.August.2023.mp4

@fisherxu
Copy link
Member

@coder12git Thanks for the contributions, but I think it should jumper to the supporters section instead of jumper a new page..

@coder12git
Copy link
Contributor Author

@coder12git Thanks for the contributions, but I think it should jumper to the supporters section instead of jumper a new page..

Okay, I will do that!

@coder12git
Supporters URL
9476890 
Signed-off-by: Suruchi Kumari <[email protected]>
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2023
@coder12git
Copy link
Contributor Author

@fisherxu Please review now, done all the changes!

Loom.Message.-.24.August.2023.mp4

fisherxu
fisherxu reviewed Aug 24, 2023
View reviewed changes
docusaurus.config.js Outdated
Comment on lines 158 to 162
{
label: "Supporters",
href: "/#supporters",
position: "left",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
label: "Supporters",
href: "/#supporters",
position: "left",
},

No need to add to nav bar :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I thought it might be helpful, anyway I removed that!

@coder12git
removed nav bar
3c729ef 
Signed-off-by: Suruchi Kumari <[email protected]>
fisherxu
fisherxu reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fisherxu
Copy link
Member

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@fisherxu
Copy link
Member

/approve

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@kubeedge-bot kubeedge-bot merged commit 1b33a2e into kubeedge:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

@Shelley-BaoYue Shelley-BaoYue Awaiting requested review from Shelley-BaoYue

Assignees

@fisherxu fisherxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coder12git @fisherxu @kubeedge-bot