Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Slider Section responsiveness #384

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fixed Slider Section responsiveness #384

merged 3 commits into from
Aug 7, 2023

Conversation

VSatwika
Copy link
Contributor

@VSatwika VSatwika commented Aug 5, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?
  • Adjusted the padding and media queries to content is displayed properly in full-size browsers as well as on smaller screens.
  • What is the current behavior?
kube1_before
  • What is the new behavior (if this is a feature change)?
kube1_after

VSatwika and others added 3 commits August 3, 2023 12:53
@VSatwika
mobile responsivenss
662e233 
Signed-off-by: VSatwika <[email protected]>
@VSatwika
responsive
6ec7fe1 
Signed-off-by: VSatwika <[email protected]>
@VSatwika
Merge pull request #1 from kubeedge/master
7e196c3 
Merge pull request kubeedge#375 from VSatwika/Links
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 5, 2023
@VSatwika
Copy link
Contributor Author

VSatwika commented Aug 5, 2023 •
edited
Loading

/assign @fisherxu

@VSatwika VSatwika removed their assignment Aug 5, 2023
@kevin-wangzefeng
Copy link
Member

/lgtm
/approve
Thanks

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@kubeedge-bot kubeedge-bot merged commit d281abd into kubeedge:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingyin dingyin Awaiting requested review from dingyin

@Shelley-BaoYue Shelley-BaoYue Awaiting requested review from Shelley-BaoYue

Assignees

@kevin-wangzefeng kevin-wangzefeng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VSatwika @kevin-wangzefeng @kubeedge-bot