fix jointinference bug

build/crds/sedna.io_datasets.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: datasets.sedna.io
 spec:

build/crds/sedna.io_featureextractionservices.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: featureextractionservices.sedna.io
 spec:

build/crds/sedna.io_federatedlearningjobs.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: federatedlearningjobs.sedna.io
 spec:

build/crds/sedna.io_incrementallearningjobs.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: incrementallearningjobs.sedna.io
 spec:

build/crds/sedna.io_lifelonglearningjobs.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: lifelonglearningjobs.sedna.io
 spec:

build/crds/sedna.io_models.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: models.sedna.io
 spec:

build/crds/sedna.io_objectsearchservices.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: objectsearchservices.sedna.io
 spec:

build/crds/sedna.io_objecttrackingservices.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: objecttrackingservices.sedna.io
 spec:

build/crds/sedna.io_reidjobs.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: reidjobs.sedna.io
 spec:

build/crds/sedna.io_videoanalyticsjobs.yaml

@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.4.1
+    controller-gen.kubebuilder.io/version: v0.6.2
   creationTimestamp: null
   name: videoanalyticsjobs.sedna.io
 spec:

pkg/apis/sedna/v1alpha1/jointinferenceservice_types.go

@@ -17,6 +17,7 @@ limitations under the License.
 package v1alpha1
 
 import (
+	autoscalingv1beta2 "k8s.io/api/autoscaling/v2beta2"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
@@ -40,26 +41,52 @@ type JointInferenceService struct {
 type JointInferenceServiceSpec struct {
 	EdgeWorker  EdgeWorker  `json:"edgeWorker"`
 	CloudWorker CloudWorker `json:"cloudWorker"`
-	HPA         HPA         `json:"hpa"`
 }
 
+// HPA describes the desired functionality of the HorizontalPodAutoscaler.
 type HPA struct {
-	MinReplicas int32    `json:"minReplicas"`
-	MaxReplicas int32    `json:"maxReplicas"`
-	Metrics     []Metric `json:"metrics"`
+	// minReplicas is the lower limit for the number of replicas to which the autoscaler
+	// can scale down.  It defaults to 1 pod.  minReplicas is allowed to be 0 if the
+	// alpha feature gate HPAScaleToZero is enabled and at least one Object or External
+	// metric is configured.  Scaling is active as long as at least one metric value is
+	// available.
+	// +optional
+	MinReplicas *int32 `json:"minReplicas,omitempty"`
+
+	// maxReplicas is the upper limit for the number of replicas to which the autoscaler can scale up.
+	// It cannot be less that minReplicas.
+	MaxReplicas int32 `json:"maxReplicas"`
+
+	// metrics contains the specifications for which to use to calculate the
+	// desired replica count (the maximum replica count across all metrics will
+	// be used).  The desired replica count is calculated multiplying the
+	// ratio between the target value and the current value by the current
+	// number of pods.  Ergo, metrics used must decrease as the pod count is
+	// increased, and vice-versa.  See the individual metric source types for
+	// more information about how each type of metric must respond.
+	// +optional
+	Metrics []autoscalingv1beta2.MetricSpec `json:"metrics,omitempty"`
+
+	// behavior configures the scaling behavior of the target
+	// in both Up and Down directions (scaleUp and scaleDown fields respectively).
+	// If not set, the default HPAScalingRules for scale up and scale down are used.
+	// +optional
+	Behavior *autoscalingv1beta2.HorizontalPodAutoscalerBehavior `json:"behavior,omitempty"`
 }
 
 // EdgeWorker describes the data a edge worker should have
 type EdgeWorker struct {
 	Model             SmallModel         `json:"model"`
 	HardExampleMining HardExampleMining  `json:"hardExampleMining"`
 	Template          v1.PodTemplateSpec `json:"template"`
+	HPA               HPA                `json:"hpa"`
 }
 
 // CloudWorker describes the data a cloud worker should have
 type CloudWorker struct {
 	Model    BigModel           `json:"model"`
 	Template v1.PodTemplateSpec `json:"template"`
+	HPA      HPA                `json:"hpa"`
 }
 
 // SmallModel describes the small model

pkg/globalmanager/controllers/featureextraction/featureextractionservice.go

@@ -150,7 +150,7 @@ func (c *Controller) addDeployment(obj interface{}) {
 	c.enqueueByDeployment(deployment)
 }
 
-//deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
+// deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
 func (c *Controller) deleteDeployment(obj interface{}) {
 	deployment, ok := obj.(*appsv1.Deployment)
 
@@ -513,7 +513,7 @@ func (c *Controller) createFeatureExtractionWorker(service *sednav1.FeatureExtra
 	}
 
 	// Create FE deployment AND related pods (as part of the deployment creation)
-	_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam, FEPort)
+	_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam)
 	if err != nil {
 		return fmt.Errorf("failed to create feature extraction deployment: %w", err)
 	}