Skip to content

Commit

Permalink
enhance joint inference controller.improve the cascade deletion.Creat…
Browse files Browse the repository at this point in the history
…e a Deployment resource instead of a Pod resource, and let the Deployment controller manage the number of Pods.automatically update deployment when modifying CRD of joint inference.add a test file to ensure the correctness of joint inference controller.

Signed-off-by: SherlockShemol <[email protected]>
  • Loading branch information
SherlockShemol committed Oct 29, 2024
1 parent 3342955 commit 55b7d88
Show file tree
Hide file tree
Showing 211 changed files with 21,054 additions and 189 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func (c *Controller) addDeployment(obj interface{}) {
c.enqueueByDeployment(deployment)
}

//deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
// deleteDeployment enqueues the FeatureExtractionService obj When a deleteDeployment is deleted
func (c *Controller) deleteDeployment(obj interface{}) {
deployment, ok := obj.(*appsv1.Deployment)

Expand Down Expand Up @@ -513,7 +513,7 @@ func (c *Controller) createFeatureExtractionWorker(service *sednav1.FeatureExtra
}

// Create FE deployment AND related pods (as part of the deployment creation)
_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam, FEPort)
_, err = runtime.CreateDeploymentWithTemplate(c.kubeClient, service, &service.Spec.DeploymentSpec, &workerParam)
if err != nil {
return fmt.Errorf("failed to create feature extraction deployment: %w", err)
}
Expand Down
Loading

0 comments on commit 55b7d88

Please sign in to comment.