Skip to content

Commit

Permalink
Merge pull request #338 from JimmyYang20/ci-pylint
Browse files Browse the repository at this point in the history
Add check pylint script
  • Loading branch information
kubeedge-bot authored Aug 15, 2022
2 parents b91cfb9 + 81f08ca commit 1011905
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 0 deletions.
16 changes: 16 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,22 @@ lint:
hack/make-rules/lint.sh
endif

define PYLINT_HELP_INFO
# run python lint check.
#
# Example:
# make pylint
# make pylint HELP=y
endef
.PHONY: pylint
ifeq ($(HELP),y)
pylint:
@echo "$$PYLINT_HELP_INFO"
else
pylint:
hack/make-rules/pylint.sh
endif

define CLEAN_HELP_INFO
# Clean up the output of make.
#
Expand Down
40 changes: 40 additions & 0 deletions hack/make-rules/pylint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#!/usr/bin/env bash

# Copyright 2020 The KubeEdge Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o errexit
set -o nounset
set -o pipefail

SEDNA_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd -P)"

source "${SEDNA_ROOT}/hack/lib/init.sh"

install_pylint() {
echo "installing pylint"
python3 -m pip install -U pylint
if [[ $? -ne 0 ]]; then
echo "failed to install pylint, exiting."
exit 1
fi
}

check_pylint() {
echo "checking pylint"
install_pylint
pylint ${SEDNA_ROOT}/lib
}

check_pylint

0 comments on commit 1011905

Please sign in to comment.