Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: #67

wants to merge 1 commit into from

Conversation

sailorvii
Copy link
Collaborator

What type of PR is this?
/kind bug

What this PR does / why we need it:

The value type of twin could not be written as "integer" but "int".
Add notice for opcua usage.

Which issue(s) this PR fixes:
Fixes #19 #9

@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 1, 2022
@kubeedge-bot kubeedge-bot requested review from luogangyi and ttlv April 1, 2022 02:23
@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2022
@sailorvii
Fix:
3fe7070 
1. The value type of twin could not be written as "integer" but "int".
2. Add notice for opcua usage.

Signed-off-by: sailorvii <[email protected]>
@sailorvii sailorvii requested review from fisherxu and removed request for luogangyi April 1, 2022 02:26
RyanZhaoXB
RyanZhaoXB approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@RyanZhaoXB RyanZhaoXB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kubeedge-bot
Copy link
Collaborator

@RyanZhaoXB: changing LGTM is restricted to collaborators

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RyanZhaoXB
To complete the pull request process, please assign sailorvii after the PR has been reviewed.
You can assign the PR to them by writing /assign @sailorvii in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RyanZhaoXB
Copy link
Collaborator

@fisherxu please help to review this pr. thanks.

@RyanZhaoXB RyanZhaoXB mentioned this pull request Jun 6, 2022
Closed
7 tasks
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@kubeedge-bot
Copy link
Collaborator

@sailorvii: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZhaoXB RyanZhaoXB RyanZhaoXB approved these changes

@ttlv ttlv Awaiting requested review from ttlv

@fisherxu fisherxu Awaiting requested review from fisherxu

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modbus&opcua device example configuration issue.
3 participants
@sailorvii @kubeedge-bot @RyanZhaoXB