Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Impl for llm edge benchmark suite #150

Merged
merged 1 commit into from
Oct 30, 2024
Merged

add Impl for llm edge benchmark suite #150

merged 1 commit into from
Oct 30, 2024

Conversation

XueSongTap
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add Impl for llm edge benchmark suite

Which issue(s) this PR fixes:

#127

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2024
@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@XueSongTap XueSongTap force-pushed the dev branch 2 times, most recently from 1988809 to 2893646 Compare September 28, 2024 07:30
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2024
@MooreZheng MooreZheng requested review from hsj576 and removed request for Poorunga October 14, 2024 03:21
MooreZheng
MooreZheng requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CI issues that remain to be resolved, see https://github.com/kubeedge/ianvs/actions/runs/11179368172?pr=150

MooreZheng
MooreZheng requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI issues are properly tackled. As discussed at the routine meeting, suggestions would be

  1. Might show a final result (e.g., ranking) in the PR;
  2. Replace the Chinese statements into English;
  3. Replace the print with loggers;

hsj576
hsj576 suggested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese prompt should be removed.

examples/llm-edge-benchmark-suite/single_task_bench/testenv/prefill_latency.py Outdated
def prefill_latency(y_true, y_pred):
# avg_prefill_latency = y_pred.get('avg_prefill_latency', [])
# return avg_prefill_latency
#TODO 前面所有歌predict_dict 的结果，可以通过下面拿出来，我想把计算平均的过程放在这里，帮我实现
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese prompt should be removed.

@XueSongTap
Copy link
Contributor Author

@hsj576 Could you please review this PR? I've made several documentation and configuration updates:

  • Comment cleanup in basemodel.py
  • Configuration parameter adjustments
  • Documentation improvements in README, including remove chinese part

Here's screenshot of the benchmark ：
image
image

The results show the changes are working as expected,

Let me know if you need any additional information or clarification.

MooreZheng
MooreZheng reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains 10 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @XueSongTap can squash the commits into one using rebase techniques.

@XueSongTap
Copy link
Contributor Author

@MooreZheng I have already addressed this concern by squashing all commits into a single commit using rebase. The changes are now consolidated into one cohesive commit for better maintenance and clearer history. Please review the updated changes.

@MooreZheng
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@MooreZheng
Copy link
Collaborator

@XueSongTap might need one more review from @hsj576

@hsj576
Copy link
Member

hsj576 commented Oct 30, 2024

/lgtm

1 similar comment
@CreativityH
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@CreativityH: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MooreZheng
MooreZheng requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid conflicts, need to change print() using logger

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@XueSongTap XueSongTap force-pushed the dev branch 2 times, most recently from aeaa8e5 to 7a1f2ae Compare October 30, 2024 14:06
add Impl for llm edge benchmark suite
5b1a925 
Signed-off-by: yexiaochuan <[email protected]>

adapt Impl in core for llm edge benchmark suite

Signed-off-by: yexiaochuan <[email protected]>

Fix impl on singletast_learning with compression

Signed-off-by: yexiaochuan <[email protected]>

chore: trigger CI

Signed-off-by: yexiaochuan <[email protected]>

CI: fix pylint warnings

Signed-off-by: yexiaochuan <[email protected]>

CI: fix pylint warnings

Signed-off-by: yexiaochuan <[email protected]>

fix: update comments and configuration parameters

Signed-off-by: yexiaochuan <[email protected]>
@XueSongTap
Copy link
Contributor Author

@MooreZheng hi, i've changed print() using logger. Could you please review this PR? Let me know if you need any additional information or clarification.

@MooreZheng
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
MooreZheng
MooreZheng approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All concerns are fixed. Well done and congratulations to @XueSongTap

@kubeedge-bot kubeedge-bot merged commit 27519de into kubeedge:main Oct 30, 2024
13 checks passed
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsj576 hsj576 hsj576 requested changes

@MooreZheng MooreZheng MooreZheng approved these changes

Assignees

@MooreZheng MooreZheng

@XueSongTap XueSongTap

@hsj576 hsj576

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XueSongTap @MooreZheng @hsj576 @CreativityH @kubeedge-bot