Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSPP: Development of Federated Incremental Learning for Label Scarcity: Base on KubeEdge-Ianvs #143

Merged
merged 1 commit into from
Oct 29, 2024
Merged

OSPP: Development of Federated Incremental Learning for Label Scarcity: Base on KubeEdge-Ianvs #143

merged 1 commit into from
Oct 29, 2024

Conversation

Yoda-wu
Copy link
Contributor

@Yoda-wu Yoda-wu commented Sep 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR add two main feature:

  • federated learning paradigm
  • federated class incremental learning paradigm

Besides this PR also add the example of these two paradigm.

Which issue(s) this PR fixes:
related issue: #97

Fixes #

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 8, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 8, 2024
@Yoda-wu Yoda-wu force-pushed the dev_script branch 2 times, most recently from 5a1a796 to 1b9b881 Compare September 8, 2024 08:23
@MooreZheng MooreZheng requested a review from hsj576 September 12, 2024 09:06
@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2024
@Yoda-wu Yoda-wu changed the title Feat: Development of Federated Incremental Learning for Label Scarcity: Base on KubeEdge-Ianvs OSPP: Development of Federated Incremental Learning for Label Scarcity: Base on KubeEdge-Ianvs Sep 22, 2024
@MooreZheng MooreZheng removed the request for review from jaypume September 26, 2024 10:11
@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@Yoda-wu Yoda-wu force-pushed the dev_script branch 2 times, most recently from 32f7aff to 8eaab3c Compare October 2, 2024 03:59
MooreZheng
MooreZheng requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three CI issues that remain to be resolved, mainly for Pylint, see https://github.com/kubeedge/ianvs/actions/runs/11137579503?pr=143

@Yoda-wu

This comment was marked as resolved.

Sign in to view
@Yoda-wu Yoda-wu mentioned this pull request Oct 17, 2024
Closed
chenhaorui0768
chenhaorui0768 suggested changes Oct 22, 2024
View reviewed changes
examples/cifar100/fci_ssl/fed_ci_match/algorithm/agumentation.py Outdated Show resolved Hide resolved
examples/cifar100/fci_ssl/fed_ci_match/algorithm/agumentation.py Outdated Show resolved Hide resolved
core/testcasecontroller/algorithm/paradigm/federated_learning/federated_learning.py Outdated Show resolved Hide resolved
examples/cifar100/fci_ssl/fedavg/algorithm/aggregation.py Outdated Show resolved Hide resolved
examples/cifar100/fci_ssl/fedavg/algorithm/basemodel.py Outdated Show resolved Hide resolved
examples/cifar100/fci_ssl/glfc/algorithm/proxy_server.py Outdated Show resolved Hide resolved
examples/cifar100/federated_class_incremental_learning/fedavg/algorithm/basemodel.py Outdated Show resolved Hide resolved
examples/cifar100/federated_class_incremental_learning/fedavg/algorithm/network.py Outdated Show resolved Hide resolved
examples/cifar100/federated_class_incremental_learning/fedavg/algorithm/resnet.py Outdated Show resolved Hide resolved
examples/cifar100/utils.py Outdated Show resolved Hide resolved
@kubeedge-bot
Copy link
Collaborator

@chenhaorui0768: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MooreZheng
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@MooreZheng
Copy link
Collaborator

MooreZheng commented Oct 22, 2024 •
edited
Loading

@hsj576 might also want to have a look at this project

hsj576
hsj576 suggested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EGG-INFO file should not be uploaded to the github repository.

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2024
@Yoda-wu
Copy link
Contributor Author

Yoda-wu commented Oct 26, 2024

The EGG-INFO file should not be uploaded to the github repository.

Sorry about that， i remove it right now

@chenhaorui0768
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@chenhaorui0768: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MooreZheng
MooreZheng reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains 8 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @Yoda-wu can squash the commits into one using rebase techniques.

@Yoda-wu
Copy link
Contributor Author

Yoda-wu commented Oct 28, 2024

This pull request contains 8 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @Yoda-wu can squash the commits into one using rebase techniques.

thank you for the advice! i will squash the commits if this pr have nothing to change. Looking forward to more reviews from @MooreZheng @chenhaorui0768 @hsj576. Due to the deadline of OSPP, please feel free to comment so i can fix it asap~

@Yoda-wu Yoda-wu force-pushed the dev_script branch 2 times, most recently from cf18fb8 to b9199de Compare October 28, 2024 04:15
@hsj576
Copy link
Member

hsj576 commented Oct 29, 2024

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@MooreZheng
Copy link
Collaborator

/lgtm

@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
MooreZheng
MooreZheng approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All concerns are fixed. Well done @Yoda-wu

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot merged commit 9553051 into kubeedge:main Oct 29, 2024
13 checks passed
@MooreZheng MooreZheng mentioned this pull request Oct 30, 2024
Merged
@Yoda-wu Yoda-wu mentioned this pull request Oct 30, 2024
Closed
@FuryMartin FuryMartin mentioned this pull request Oct 30, 2024
Merged
@Yoda-wu Yoda-wu mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsj576 hsj576 hsj576 requested changes

@chenhaorui0768 chenhaorui0768 chenhaorui0768 requested changes

@MooreZheng MooreZheng MooreZheng approved these changes

Assignees

@MooreZheng MooreZheng

@chenhaorui0768 chenhaorui0768

@hsj576 hsj576

@Yoda-wu Yoda-wu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yoda-wu @kubeedge-bot @MooreZheng @chenhaorui0768 @hsj576