Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job center instructions #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shelley-BaoYue
Copy link
Collaborator

add job center post a job instructions

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2023
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, thanks.

job-center/instructions.md Outdated Show resolved Hide resolved
job-center/instructions.md Outdated Show resolved Hide resolved
Signed-off-by: Shelley-BaoYue <[email protected]>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign benjaminhuo after the PR has been reviewed.
You can assign the PR to them by writing /assign @benjaminhuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shelley-BaoYue
Copy link
Collaborator Author

Minor comments, thanks.

Modification has completed. Thanks for your suggestions.

Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having the duplication from https://github.com/kubeedge/website/blob/master/src/components/jobCard/README.md, why dont we have a quick URL link to navigate the users to https://github.com/kubeedge/website/tree/master/src/components/jobCard? to reduce maintenance cost. (duplication problem such as inconsistent documentation)

my comment should not block the PR, i will leave this to maintainers.

@@ -0,0 +1,38 @@
# POST A JOB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# POST A JOB
# KubeEdge Careers
[KubeEdge Job Center](https://kubeedge.io/job-center/) is the central repository to post and find the jobs related to KubeEdge.
Guidelines and tutorials for posting the jobs are available to [here](https://github.com/kubeedge/website/tree/master/src/components/jobCard).


We hope that you can provide as much detailed information as possible about the job.

1. Please add the following information at the top of the document. This information will be displayed in a card format on the KubeEdge official website's job center homepage, which will help community users quickly understand the key information about the job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the top of the document

i think this is hard to understand to go from this repository. instead, we would probably specify where to change, https://github.com/kubeedge/website/tree/master/src/pages/job-center?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the top of the document

i think this is hard to understand to go from this repository. instead, we would probably specify where to change, https://github.com/kubeedge/website/tree/master/src/pages/job-center?

If put thie markdown file(README.md/instructions.md) at https://github.com/kubeedge/website/tree/master/src/pages/job-center, the website docusaurus plugin will identifie the markdown file as a job and display it on the job card, so I initially put it in the jobCard directory. Thank you for your suggestions. We can further consider where would be more appropriate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If put thie markdown file(README.md/instructions.md) at https://github.com/kubeedge/website/tree/master/src/pages/job-center

i did not mean this. i was thinking about the top of the document, probably we would want to change it into [job-center](https://github.com/kubeedge/website/tree/master/src/pages/job-center) instead? so that user can know where to add the following documents to.

@Shelley-BaoYue
Copy link
Collaborator Author

instead of having the duplication from https://github.com/kubeedge/website/blob/master/src/components/jobCard/README.md, why dont we have a quick URL link to navigate the users to https://github.com/kubeedge/website/tree/master/src/components/jobCard? to reduce maintenance cost. (duplication problem such as inconsistent documentation)

my comment should not block the PR, i will leave this to maintainers.

After this PR merged, I will remove https://github.com/kubeedge/website/blob/master/src/components/jobCard/README.md. It won't take more maintenance cost.

@Shelley-BaoYue
Copy link
Collaborator Author

I have moved this file to website/docs with PR kubeedge/website#443. Users can get the guide in website documentation like https://deploy-preview-443--competent-hypatia-4195b7.netlify.app/docs/community/jobcenter. I think this is more appropriate than putting the guide in the community repo here.
PTAL @kevin-wangzefeng @fujitatomoya @fisherxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants