Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create space method for dashboard #95

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add create space method for dashboard #95

merged 2 commits into from
Apr 19, 2024

Conversation

ishtiaqhimel
Copy link
Member

No description provided.

@ishtiaqhimel
Create spaces for dashboard
33742df 
Signed-off-by: Md. Ishtiaq Islam <[email protected]>
raihankhan
raihankhan requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this map in a constant and re-use everywhere? May be name it jsonHeaderForKibanaAPI

map[string]string{
"Content-Type": "application/json",
"kbn-xsrf":     "true",
}

elasticsearchdashboard/ed_client_v8.go Outdated Show resolved Hide resolved
@ishtiaqhimel
Add jsonHeaderForKibanaAPI var
14f03ee 
Signed-off-by: Md. Ishtiaq Islam <[email protected]>
raihankhan
raihankhan approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@raihankhan raihankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raihankhan raihankhan merged commit f4fab3d into master Apr 19, 2024
5 checks passed
@raihankhan raihankhan deleted the create-space branch April 19, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raihankhan raihankhan raihankhan approved these changes

@hmsayem hmsayem Awaiting requested review from hmsayem

@anisurrahman75 anisurrahman75 Awaiting requested review from anisurrahman75

@pritamdas99 pritamdas99 Awaiting requested review from pritamdas99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishtiaqhimel @raihankhan