Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cassandra Client #130

Merged
merged 21 commits into from
Sep 20, 2024
Merged

Add Cassandra Client #130

merged 21 commits into from
Sep 20, 2024

Conversation

sabbir-hossain70
Copy link
Member

@sabbir-hossain70 sabbir-hossain70 commented Aug 14, 2024

Fixes kubedb/internal#1221

Copy link

gitguardian bot commented Aug 14, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13338731 Triggered Username Password 5166a81 cassandra/kubedb_client_builder.go View secret
13338731 Triggered Username Password 043ccfa cassandra/kubedb_client_builder.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2024

CLA assistant check
All committers have signed the CLA.

@sabbir-hossain70 sabbir-hossain70 force-pushed the cassandra branch 2 times, most recently from 76bd8ad to fd1a768 Compare August 21, 2024 06:53
@sabbir-hossain70 sabbir-hossain70 changed the title Add db-client-go for Cassandra Add Cassandra Client Aug 21, 2024
@sabbir-hossain70 sabbir-hossain70 force-pushed the cassandra branch 2 times, most recently from 1fb863f to 5053d6c Compare September 6, 2024 04:35
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Sabbir <[email protected]>
cassandra/client.go Show resolved Hide resolved
cassandra/client.go Show resolved Hide resolved
Signed-off-by: Sabbir <[email protected]>
Signed-off-by: Tapajit Chandra Paul <[email protected]>
Copy link
Member

@tapojit047 tapojit047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArnobKumarSaha ArnobKumarSaha merged commit e11cb0a into master Sep 20, 2024
5 checks passed
@ArnobKumarSaha ArnobKumarSaha deleted the cassandra branch September 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants