Add argument to send_command and send_command_timing to support raising exception for parsers #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow exceptions from structured data parsers to bubble up to the callers of `send_command` and `send_command_timing`. This is useful for example in conjunction with `nornir_netmiko`, which currently can't fail tasks based on failed parsing, leading to successful tasks with garbage data.
…TextFSM; additional tests
|
@Kircheneer I made some updates to make this more ubiquitous across TTP/Genie. I also changed the behavior for TextFSM such that NetmikoParsingException is raised both for a failure to find a template and also for a valid template with some set of data that isn't parsed properly (or worded differently CLITable exception won't be raised generally NetmikoParsingException would be raised with a different message). Let me know if this causes issues (part of the reason for me wanting to do this was to make the behavior more consistent across TTP and Genie). |
|
@tom0010 See comments to @Kircheneer (let me know if you have any feedback, otherwise, will probably merge tomorrow). We can obviously adjust after it is merged (if necessary). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextFSM/TTP/Genie failures should result in a NetmikoParsingException when this flag is set and an error occurs.