Vendor telnetlib library #3444
Vendor telnetlib library #3444
Conversation
|
TODO: Regression test on PY3.8 through PY3.13 to some real devices using telnet. |
|
pyats/genie are causing PY3.12 to break. I will have to look at this separately. |
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["poetry==1.3.2"] | |||
| requires = ["poetry==1.8.3"] | |||
There was a problem hiding this comment.
Side comment: I'm forced to override this in the RPM packaging since the chances of having exactly this version of Poetry are not high.
There was a problem hiding this comment.
Okay, I will relax to make it >= 1.6.1 or something close to that. There was an issue with PY3.13 and Poetry ~1.3.1 (IIRC).
|
@ktbyers as long as it passes tests under Python 3.13, it's good for me, thanks much! Do you want to update |
.github/workflows/main_testing.yaml
Outdated
| @@ -57,7 +52,9 @@ jobs: | |||
| shell: bash | |||
| strategy: | |||
| matrix: | |||
| python-version: [ '3.8', '3.9', '3.10', '3.11' ] | |||
| # pyats and genie breakage on newer python versions. | |||
There was a problem hiding this comment.
Pardon my ignorance, is it possible to run a subset of tests without these dependencies?
|
@dtantsur Okay, specified a wider range for Poetry versions; cleaned up So most of the testing now works on PY38 through PY313 Still need to do some manual telnet testing using this branch before I want to merge, but I think everything else is good-to-go from my perspective. |
|
Tested cisco_ios and telnet using PY3.9, PY3.10, and PY3.11 (config and show commands). The other three were (somewhat) difficult to run the live test suite against given my current setup (PY3.8, PY3.12, PY3.13)...I doubt any differences matter here (i.e. the differences should have been caught in the unit tests). |
|
@ktbyers thank you so much for your cooperation! Could you make a release with this change? I can pick up the version from git, but it's somewhat easier with an official release. |
|
@dtantsur FYI, this version of Netmiko was released today to pypi (Netmiko 4.4.0) |
|
Yep, thank you, already uploaded to Fedora! |
Fixes #3177