Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hill-a#1007
Description
Changed call to
writer.add_summary
to use self.num_timesteps in the case that num_timesteps is not reset after multiple calls tomodel.learn(..., reset_num_timesteps=False)
.Motivation and Context
Issues Tensorboard Logging Issue after multiple consecutive calls to self.learn(..., reset_num_timesteps=False) hill-a/stable-baselines#1007 shows an example where tensorboard plotted line is discontinuous due to incorrect step counter
Types of changes
Checklist:
pytest
andpytype
both pass (by runningmake pytest
andmake type
).