Skip to content

Commit

Permalink
Mention that -distributor.shard-by-all-labels is used by querier too. (
Browse files Browse the repository at this point in the history
…cortexproject#2750)

Some people assume querier has its own version of this flag.

Signed-off-by: Peter Štibraný <[email protected]>
  • Loading branch information
pstibrany authored Jun 18, 2020
1 parent 8536385 commit a40db4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/configuration/arguments.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ The ingester query API was improved over time, but defaults to the old behaviour

Set this flag to `true` for the new behaviour.

Important to note is that when setting this flag to `true`, it has to be set on both the distributor and the querier. If the flag is only set on the distributor and not on the querier, you will get incomplete query results because not all ingesters are queried.
Important to note is that when setting this flag to `true`, it has to be set on both the distributor and the querier (called `-distributor.shard-by-all-labels` on Querier as well). If the flag is only set on the distributor and not on the querier, you will get incomplete query results because not all ingesters are queried.

**Upgrade notes**: As this flag also makes all queries always read from all ingesters, the upgrade path is pretty trivial; just enable the flag. When you do enable it, you'll see a spike in the number of active series as the writes are "reshuffled" amongst the ingesters, but over the next stale period all the old series will be flushed, and you should end up with much better load balancing. With this flag enabled in the queriers, reads will always catch all the data from all ingesters.

Expand Down

0 comments on commit a40db4c

Please sign in to comment.