Fix test bed #110
Merged
Fix test bed #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from kripken#87 (comment).
kripken
reviewed
Apr 20, 2020
demo/html5canvas/testbed.html
Outdated
| @@ -21,6 +21,9 @@ | |||
| <script type="text/javascript"> | |||
| var Box2D; | |||
| if (!Box2D) Box2D = (typeof Box2D !== 'undefined' ? Box2D : null) || Module; | |||
| var Box2DConstructor = Box2D | |||
demo/html5canvas/testbed.html
Outdated
| @@ -21,6 +21,9 @@ | |||
| <script type="text/javascript"> | |||
| var Box2D; | |||
| if (!Box2D) Box2D = (typeof Box2D !== 'undefined' ? Box2D : null) || Module; | |||
| var Box2DConstructor = Box2D | |||
| Box2D = Box2D() | |||
| Module = Box2D | |||
There was a problem hiding this comment.
I removed line 24 (Box2DConstructor) but if I remove the other 2 lines, I get this error message:
Uncaught TypeError: Box2D.JSDraw is not a constructor
at getCanvasDebugDraw (embox2d-html5canvas-debugDraw.js:85)
at init (embox2d-html5canvas-testbed.js:275)
at window.onload (testbed.html:27)
I think those 2 lines are essential to the working of the test bed.
kripken
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the solution from #87 (comment) and fix script loading error to make the test bed work again.
Fixes #97.