forked from jupyterlab/jupyterlab
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor workspaces to provide a scaffold for Workspaces UI #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
workspace-manager
branch
from
February 2, 2024 14:21
ba6efde
to
6d07b11
Compare
krassowski
force-pushed
the
workspace-manager
branch
from
March 5, 2024 14:42
6d07b11
to
7cf83fa
Compare
github-actions
bot
added
documentation
Improvements or additions to documentation
pkg:debugger
pkg:fileeditor
pkg:rendermime
pkg:notebook
tag:Examples
tag:Testing
pkg:application
pkg:attachments
pkg:cell-toolbar
pkg:cells
pkg:celltags
pkg:codeeditor
pkg:codemirror
pkg:completer
pkg:console
pkg:coreutils
pkg:csvviewer
pkg:docmanager
pkg:docregistry
pkg:documentsearch
pkg:extensionmanager
pkg:filebrowser
pkg:help
labels
Mar 5, 2024
workspace from file, adding workspaces by command, and context menu. Fix minor issue with docs formatting/linking.
krassowski
force-pushed
the
workspace-manager
branch
from
March 11, 2024 10:30
7e5d4f6
to
505e5c7
Compare
Wait for launcher to avoid flaky snapshot Add snapshot for sidebar
Add snapshot for workspaces submenu
krassowski
force-pushed
the
workspace-manager
branch
from
March 11, 2024 12:30
505e5c7
to
5dc0a2e
Compare
krassowski
force-pushed
the
workspace-manager
branch
from
March 15, 2024 11:08
d2c1ae3
to
bcf8dfc
Compare
to avoid confusion when workspace is named with a word
Co-authored-by: Jason Weill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Design System CSS
documentation
Improvements or additions to documentation
feature
pkg:application
pkg:apputils
pkg:attachments
pkg:cell-toolbar
pkg:cells
pkg:celltags
pkg:codeeditor
pkg:codemirror
pkg:completer
pkg:console
pkg:coreutils
pkg:csvviewer
pkg:debugger
pkg:docmanager
pkg:docregistry
pkg:documentsearch
pkg:extensionmanager
pkg:filebrowser
pkg:fileeditor
pkg:help
pkg:htmlviewer
pkg:hub
pkg:imageviewer
pkg:inspector
pkg:javascript
pkg:json
pkg:launcher
pkg:logconsole
pkg:lsp
pkg:mainmenu
pkg:markdownviewer
pkg:mathjax
pkg:mermaid
pkg:metadataform
pkg:notebook
pkg:observables
pkg:outputarea
pkg:pdf
pkg:pluginmanager
pkg:property-inspector
pkg:rendermime
pkg:running
pkg:services
pkg:settingeditor
pkg:settingregistry
pkg:shortcuts
pkg:statedb
pkg:statusbar
pkg:terminal
pkg:themes
pkg:toc
pkg:tooltip
pkg:translation
pkg:ui-components
pkg:vega
tag:CSS
tag:Examples
tag:Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
apputils-extension:workspaces
to dedicatedworkspaces-extension
.jupyter-workspace
files on click was retained inapputils-extension:workspaces
for now (STC); it can stay there because (a) this is not needed inworkspaces-extension
and (b) this way we do not removeapputils-extension:workspaces
plugin (reducing friction for users who disabled it before)open
commandsaveAs
logic by usingInputDialog.getText()
(which gives us pre-selection and placeholder)TODO:
workspaces
(for now only a single token) andworkspaces-extension
or just the latterUser-facing changes
Backwards-incompatible changes
None