Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workspaces to provide a scaffold for Workspaces UI #94

Closed
wants to merge 30 commits into from

Conversation

krassowski
Copy link
Owner

@krassowski krassowski commented Jan 23, 2024

References

Code changes

  • move workspace logic and commands from apputils-extension:workspaces to dedicated workspaces-extension
    • this enables building upon these commands
    • the mime extension that .jupyter-workspace files on click was retained in apputils-extension:workspaces for now (STC); it can stay there because (a) this is not needed in workspaces-extension and (b) this way we do not remove apputils-extension:workspaces plugin (reducing friction for users who disabled it before)
  • add open command
  • add commands to command palette
  • simplify saveAs logic by using InputDialog.getText() (which gives us pre-selection and placeholder)

TODO:

  • decide if we want to have both workspaces (for now only a single token) and workspaces-extension or just the latter

User-facing changes

Backwards-incompatible changes

None

workspace from file, adding workspaces by command, and context menu.
Fix minor issue with docs formatting/linking.
@krassowski krassowski closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment