Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug ci #139

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Debug ci #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9e2b82
Run CI on Python 3.9 and 3.13 (drop 3.8 from testing matrix) (#16852)
krassowski Nov 20, 2024
f2ccf6b
Restore viewport `min-height` when not windowing (#16979)
brichet Nov 21, 2024
006a459
Drag image prompt styling (#16972)
JasonWeill Nov 21, 2024
a94535e
Pin Python version for visual regression testing to 3.11
krassowski Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/galata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.11"

- name: Set up browser cache
uses: actions/cache@v4
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/linuxjs-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@ jobs:
name: JS
strategy:
matrix:
# Fix for https://github.com/jupyterlab/jupyterlab/issues/13903
include:
- group: js-debugger
python-version: '3.11'
python-version: ["3.13"]
group:
[
js-application,
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/linuxtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,35 +15,35 @@ jobs:
matrix:
group: [integrity, integrity2, integrity3, release_test, docs, usage, usage2, splice_source, python, examples, interop, nonode, lint]
# This will be used by the base setup action
python-version: ["3.8", "3.12"]
python-version: ["3.9", "3.13"]
include:
- group: examples
upload-output: true
- group: release_test
upload-output: true
exclude:
- group: integrity
python-version: "3.8"
python-version: "3.9"
- group: integrity2
python-version: "3.8"
python-version: "3.9"
- group: integrity3
python-version: "3.8"
python-version: "3.9"
- group: release_test
python-version: "3.8"
python-version: "3.9"
- group: docs
python-version: "3.8"
python-version: "3.9"
- group: usage
python-version: "3.8"
python-version: "3.9"
- group: usage2
python-version: "3.8"
python-version: "3.9"
- group: nonode
python-version: "3.8"
python-version: "3.9"
- group: lint
python-version: "3.8"
python-version: "3.9"
- group: examples
python-version: "3.8"
python-version: "3.9"
- group: splice_source
python-version: "3.8"
python-version: "3.9"
fail-fast: false
timeout-minutes: 45
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
with:
python_version: "3.8"
python_version: "3.9"
dependency_type: minimum
- name: Install dependencies
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macostests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
strategy:
matrix:
group: [integrity, python, usage, usage2]
python-version: [3.11]
python-version: [3.12]
include:
- group: python
python-version: 3.12
python-version: 3.13
fail-fast: false
timeout-minutes: 45
runs-on: macos-latest
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/windowstests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
strategy:
matrix:
group: [integrity, python]
python-version: ["3.13"]
fail-fast: false
runs-on: windows-latest
timeout-minutes: 40
Expand Down
9 changes: 8 additions & 1 deletion packages/notebook/style/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@
flex: 0 0 auto;
min-width: 36px;
color: var(--jp-cell-inprompt-font-color);
opacity: 0.5;
padding: var(--jp-code-padding);
padding-left: 12px;
font-family: var(--jp-cell-prompt-font-family);
Expand All @@ -221,7 +222,13 @@
top: 8px;
left: 8px;
background: var(--jp-layout-color2);
border: var(--jp-border-width) solid var(--jp-input-border-color);
border-width: var(--jp-border-width);
border-style: solid;
border-color: color-mix(
in srgb,
var(--jp-input-border-color) 20%,
transparent
);
box-shadow: 2px 2px 4px 0 rgba(0, 0, 0, 0.12);
}

Expand Down
1 change: 1 addition & 0 deletions packages/ui-components/src/components/windowedlist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,7 @@ export class WindowedList<
private _applyNoWindowingStyles() {
this._viewport.style.position = 'relative';
this._viewport.style.top = '0px';
this._viewport.style.minHeight = '';
this._innerElement.style.height = '';
}
/**
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dependencies = [
"jupyterlab_server>=2.27.1,<3",
"notebook_shim>=0.2",
"packaging",
"setuptools>=40.1.0",
"setuptools>=41.1.0",
"tomli>=1.2.2;python_version<\"3.11\"",
"tornado>=6.2.0",
"traitlets",
Expand Down
Loading