Integrity, lint (async catch) and reduce API surface

by removing protected method used in only one place
krassowski · Mar 11, 2024 · 98b7dfd · 98b7dfd
1 parent 63c3e30
commit 98b7dfd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/packages/docmanager/package.json b/packages/docmanager/package.json
@@ -54,6 +54,7 @@
     "@lumino/coreutils": "^2.1.2",
     "@lumino/disposable": "^2.1.2",
     "@lumino/messaging": "^2.0.1",
+    "@lumino/polling": "^2.1.2",
     "@lumino/properties": "^2.0.1",
     "@lumino/signaling": "^2.1.2",
     "@lumino/widgets": "^2.3.1",

diff --git a/packages/docmanager/src/recents.ts b/packages/docmanager/src/recents.ts
@@ -197,7 +197,7 @@ export class RecentsManager implements IRecentsManager, IDisposable {
           return a.root !== this._serverRoot ? 1 : -1;
         }
       });
-    this.saveRecents();
+    this._saveDebouncer.invoke().catch(console.warn);
   }
 
   /**
@@ -237,13 +237,6 @@ export class RecentsManager implements IRecentsManager, IDisposable {
     return invalidPathsOrNulls.filter(x => typeof x === 'string') as string[];
   }
 
-  /**
-   * Save the recent items to the state with debouncing.
-   */
-  protected saveRecents(): void {
-    this._saveDebouncer.invoke();
-  }
-
   /**
    * Save the recent items to the state.
    */

diff --git a/yarn.lock b/yarn.lock
@@ -2901,6 +2901,7 @@ __metadata:
     "@lumino/coreutils": ^2.1.2
     "@lumino/disposable": ^2.1.2
     "@lumino/messaging": ^2.0.1
+    "@lumino/polling": ^2.1.2
     "@lumino/properties": ^2.0.1
     "@lumino/signaling": ^2.1.2
     "@lumino/widgets": ^2.3.1