Windowed notebook page down handling #349
galata.yml
on: pull_request
Visual Regression Tests
36m 25s
Matrix: Visual Regression Documentation
Annotations
10 errors, 3 warnings, and 2 notices
[documentation] › test/documentation/general.test.ts:20:7 › General › Welcome:
core/galata/test/documentation/general.test.ts#L82
1) [documentation] › test/documentation/general.test.ts:20:7 › General › Welcome ─────────────────
Error: Screenshot comparison failed:
54 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-expected.png
Received: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-actual.png
Diff: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-diff.png
80 | await page.mouse.up();
81 |
> 82 | expect(await page.screenshot()).toMatchSnapshot('jupyterlab.png');
| ^
83 | });
84 |
85 | test('Left Sidebar', async ({ page }) => {
at /home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/general.test.ts:82:37
|
[documentation] › test/documentation/general.test.ts:549:7 › General › Kernels and Terminals:
core/galata/test/documentation/general.test.ts#L580
2) [documentation] › test/documentation/general.test.ts:549:7 › General › Kernels and Terminals ──
Error: Screenshot comparison failed:
506 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Kernels-and-Terminals-documentation/running-layout-expected.png
Received: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Kernels-and-Terminals-documentation/running-layout-actual.png
Diff: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Kernels-and-Terminals-documentation/running-layout-diff.png
578 | expect(
579 | await page.screenshot({ clip: { y: 27, x: 0, width: 283, height: 400 } })
> 580 | ).toMatchSnapshot('running_layout.png');
| ^
581 | });
582 |
583 | test('Command Palette', async ({ page }) => {
at /home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/general.test.ts:580:7
|
[jupyterlab] › test/jupyterlab/notebook-markdown.test.ts:86:7 › Notebook Markdown › Render a MermaidJS error:
galata/test/jupyterlab/notebook-markdown.test.ts#L90
1) [jupyterlab] › test/jupyterlab/notebook-markdown.test.ts:86:7 › Notebook Markdown › Render a MermaidJS error
Error: Screenshot comparison failed:
Expected an image 674px by 156px, received 674px by 23px. 3409 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-markdown-Notebook-Markdown-Render-a-MermaidJS-error-jupyterlab/render-mermaid-error-expected.png
Received: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-markdown-Notebook-Markdown-Render-a-MermaidJS-error-jupyterlab/render-mermaid-error-actual.png
Diff: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-markdown-Notebook-Markdown-Render-a-MermaidJS-error-jupyterlab/render-mermaid-error-diff.png
88 | const imageName = 'render-mermaid-error.png';
89 | const cell = await page.notebook.getCellLocator(4);
> 90 | expect(await cell!.screenshot()).toMatchSnapshot(imageName);
| ^
91 | });
92 | });
93 |
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-markdown.test.ts:90:38
|
[jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs:
galata/test/jupyterlab/notebook-run.test.ts#L62
2) [jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs
Error: Screenshot comparison failed:
316 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-expected.png
Received: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-actual.png
Diff: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-diff.png
60 |
61 | for (let c = 0; c < numNBImages; ++c) {
> 62 | expect.soft(captures[c]).toMatchSnapshot(getCaptureImageName(c));
| ^
63 | }
64 | });
65 |
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-run.test.ts:62:32
|
[jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:181:7 › Notebook scroll on execution (no windowing) › should scroll when advancing if top is only marginally visible:
galata/test/jupyterlab/notebook-scroll-no-windowing.test.ts#L203
3) [jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:181:7 › Notebook scroll on execution (no windowing) › should scroll when advancing if top is only marginally visible
Error: expect(received).toBeInViewport()
Call log:
- expect.toBeInViewport with timeout 5000ms
- waiting for getByRole('main').locator('[role="tabpanel"][id="id-1d153faa-c1c8-425d-aaee-36d178b4f080"]').locator('.jp-NotebookPanel-notebook').first().locator('.jp-Cell[data-windowed-list-index="2"]')
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- waiting for getByRole('main').locator('[role="tabpanel"][id="id-1d153faa-c1c8-425d-aaee-36d178b4f080"]').locator('.jp-NotebookPanel-notebook').first().locator('.jp-Cell[data-windowed-list-index="2"]')
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
- locator resolved to <div tabindex="0" data-windowed-list-index="2" aria-l…>…</div>
- unexpected value "viewport ratio 0.009747706353664398"
201 |
202 | // After running the second cell, the third cell should be revealed, in at least 10%
> 203 | await expect(thirdCell!).toBeInViewport({ ratio: 0.1 });
| ^
204 |
205 | // The third cell should now occupy about half of the notebook viewport
206 | expect(await notebookViewportRatio(notebook!, thirdCell!)).toBeGreaterThan(
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-scroll-no-windowing.test.ts:203:30
|
[jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:282:7 › Notebook scroll over long outputs (no windowing) › should scroll smoothly without snapping to headings:
galata/test/jupyterlab/notebook-scroll-no-windowing.test.ts#L289
4) [jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:282:7 › Notebook scroll over long outputs (no windowing) › should scroll smoothly without snapping to headings
TimeoutError: locator.waitFor: Timeout 100ms exceeded.
=========================== logs ===========================
waiting for locator('.jp-Cell .jp-RenderedMarkdown:has-text("Before")') to be visible
============================================================
287 | );
288 | // Wait until Markdown cells are rendered
> 289 | await renderedMarkdownLocator.waitFor({ timeout: 100 });
| ^
290 | // Un-render the "before" markdown cell
291 | await renderedMarkdownLocator.dblclick();
292 | // Make the first cell active
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-scroll-no-windowing.test.ts:289:35
|
[jupyterlab] › test/jupyterlab/toc-running.test.ts:50:7 › ToC Running indicator › should display error indicators:
galata/test/jupyterlab/toc-running.test.ts#L10
5) [jupyterlab] › test/jupyterlab/toc-running.test.ts:50:7 › ToC Running indicator › should display error indicators
Test timeout of 60000ms exceeded while running "beforeEach" hook.
8 |
9 | test.describe('ToC Running indicator', () => {
> 10 | test.beforeEach(async ({ page, tmpPath }) => {
| ^
11 | await page.notebook.openByPath(`${tmpPath}/${fileName}`);
12 | await page.notebook.activate(fileName);
13 |
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/toc-running.test.ts:10:8
|
[jupyterlab] › test/jupyterlab/toc-running.test.ts:50:7 › ToC Running indicator › should display error indicators:
galata/src/helpers/filebrowser.ts#L71
5) [jupyterlab] › test/jupyterlab/toc-running.test.ts:50:7 › ToC Running indicator › should display error indicators
Error: locator.count: Target page, context or browser has been closed
at src/helpers/filebrowser.ts:71
69 | .getByRole('listitem', { name: new RegExp(`^Name: ${fileName}`) });
70 |
> 71 | return (await item.count()) > 0;
| ^
72 | }
73 |
74 | /**
at FileBrowserHelper.isFileListedInBrowser (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/filebrowser.ts:71:24)
at fn (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/filebrowser.ts:57:45)
at Timeout.check (/home/runner/work/jupyterlab/jupyterlab/galata/src/utils.ts:183:33)
|
[jupyterlab] › test/jupyterlab/toc-running.test.ts:63:7 › ToC Running indicator › should display running indicator on first visible top level:
galata/test/jupyterlab/toc-running.test.ts#L10
6) [jupyterlab] › test/jupyterlab/toc-running.test.ts:63:7 › ToC Running indicator › should display running indicator on first visible top level
Test timeout of 60000ms exceeded while running "beforeEach" hook.
8 |
9 | test.describe('ToC Running indicator', () => {
> 10 | test.beforeEach(async ({ page, tmpPath }) => {
| ^
11 | await page.notebook.openByPath(`${tmpPath}/${fileName}`);
12 | await page.notebook.activate(fileName);
13 |
at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/toc-running.test.ts:10:8
|
[jupyterlab] › test/jupyterlab/toc-running.test.ts:63:7 › ToC Running indicator › should display running indicator on first visible top level:
galata/src/helpers/filebrowser.ts#L71
6) [jupyterlab] › test/jupyterlab/toc-running.test.ts:63:7 › ToC Running indicator › should display running indicator on first visible top level
Error: locator.count: Target page, context or browser has been closed
at src/helpers/filebrowser.ts:71
69 | .getByRole('listitem', { name: new RegExp(`^Name: ${fileName}`) });
70 |
> 71 | return (await item.count()) > 0;
| ^
72 | }
73 |
74 | /**
at FileBrowserHelper.isFileListedInBrowser (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/filebrowser.ts:71:24)
at fn (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/filebrowser.ts:57:45)
at Timeout.check (/home/runner/work/jupyterlab/jupyterlab/galata/src/utils.ts:183:33)
|
Visual Regression Documentation (3.10.6)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Visual Regression Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Visual Regression Tests
No files were found with the provided path: galata/test-jupyterlab-results
galata/test-results. No artifacts will be uploaded.
|
🎭 Playwright Run Summary
2 flaky
[documentation] › test/documentation/general.test.ts:20:7 › General › Welcome ──────────────────
[documentation] › test/documentation/general.test.ts:549:7 › General › Kernels and Terminals ───
60 passed (5.5m)
|
🎭 Playwright Run Summary
6 flaky
[jupyterlab] › test/jupyterlab/notebook-markdown.test.ts:86:7 › Notebook Markdown › Render a MermaidJS error
[jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs
[jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:181:7 › Notebook scroll on execution (no windowing) › should scroll when advancing if top is only marginally visible
[jupyterlab] › test/jupyterlab/notebook-scroll-no-windowing.test.ts:282:7 › Notebook scroll over long outputs (no windowing) › should scroll smoothly without snapping to headings
[jupyterlab] › test/jupyterlab/toc-running.test.ts:50:7 › ToC Running indicator › should display error indicators
[jupyterlab] › test/jupyterlab/toc-running.test.ts:63:7 › ToC Running indicator › should display running indicator on first visible top level
419 passed (29.4m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
jupyterlab-documentation-report
Expired
|
2.34 MB |
|
jupyterlab-documentation-test-assets
Expired
|
1.53 MB |
|
jupyterlab-galata-report
Expired
|
5.25 MB |
|