Skip to content

Windowed notebook does not update window on panel resize #185

Windowed notebook does not update window on panel resize

Windowed notebook does not update window on panel resize #185

Triggered via pull request November 5, 2023 14:56
Status Failure
Total duration 1h 10m 35s
Artifacts 4

galata.yml

on: pull_request
Visual Regression Tests
1h 10m
Visual Regression Tests
Matrix: Visual Regression Documentation
Fit to window
Zoom out
Zoom in

Annotations

13 errors, 2 warnings, and 2 notices
[documentation] › test/documentation/debugger.test.ts:276:7 › Debugger › Breakpoints panel: core/galata/src/helpers/notebook.ts#L886
1) [documentation] › test/documentation/debugger.test.ts:276:7 › Debugger › Breakpoints panel ──── TypeError: Cannot read properties of undefined (reading 'click') at src/helpers/notebook.ts:886 884 | return false; 885 | } > 886 | await gutters[lineNumber].click(); | ^ 887 | return true; 888 | } 889 | at NotebookHelper.clickCellGutter (/home/runner/work/jupyterlab/jupyterlab/core/galata/src/helpers/notebook.ts:886:31) at setBreakpoint (/home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/debugger.test.ts:357:3) at /home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/debugger.test.ts:285:5
[documentation] › test/documentation/debugger.test.ts:306:7 › Debugger › Source panel: core/galata/src/helpers/notebook.ts#L886
2) [documentation] › test/documentation/debugger.test.ts:306:7 › Debugger › Source panel ───────── TypeError: Cannot read properties of undefined (reading 'click') at src/helpers/notebook.ts:886 884 | return false; 885 | } > 886 | await gutters[lineNumber].click(); | ^ 887 | return true; 888 | } 889 | at NotebookHelper.clickCellGutter (/home/runner/work/jupyterlab/jupyterlab/core/galata/src/helpers/notebook.ts:886:31) at setBreakpoint (/home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/debugger.test.ts:357:3) at /home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/debugger.test.ts:315:5
[documentation] › test/documentation/general.test.ts:19:7 › General › Welcome: core/galata/test/documentation/general.test.ts#L79
3) [documentation] › test/documentation/general.test.ts:19:7 › General › Welcome ───────────────── Error: Screenshot comparison failed: 54 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-expected.png Received: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-actual.png Diff: /home/runner/work/jupyterlab/jupyterlab/core/galata/test-results/test-documentation-general-General-Welcome-documentation/jupyterlab-diff.png 77 | await page.mouse.up(); 78 | > 79 | expect(await page.screenshot()).toMatchSnapshot('jupyterlab.png'); | ^ 80 | }); 81 | 82 | test('Overview', async ({ page }) => { at /home/runner/work/jupyterlab/jupyterlab/core/galata/test/documentation/general.test.ts:79:37
[jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs: galata/test/jupyterlab/notebook-run.test.ts#L62
1) [jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs Error: Screenshot comparison failed: 316 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-expected.png Received: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-actual.png Diff: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab/notebook-panel-1-diff.png 60 | 61 | for (let c = 0; c < numNBImages; ++c) { > 62 | expect.soft(captures[c]).toMatchSnapshot(getCaptureImageName(c)); | ^ 63 | } 64 | }); 65 | at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-run.test.ts:62:32
[jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs: galata/test/jupyterlab/notebook-run.test.ts#L62
1) [jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 316 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab-retry1/notebook-panel-1-expected.png Received: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab-retry1/notebook-panel-1-actual.png Diff: /home/runner/work/jupyterlab/jupyterlab/galata/test-results/test-jupyterlab-notebook-run-Notebook-Run-Run-Notebook-and-capture-cell-outputs-jupyterlab-retry1/notebook-panel-1-diff.png 60 | 61 | for (let c = 0; c < numNBImages; ++c) { > 62 | expect.soft(captures[c]).toMatchSnapshot(getCaptureImageName(c)); | ^ 63 | } 64 | }); 65 | at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/notebook-run.test.ts:62:32
[jupyterlab] › test/jupyterlab/windowed-notebook.test.ts:41:5 › should update window height on resize: galata/test/jupyterlab/windowed-notebook.test.ts#L59
2) [jupyterlab] › test/jupyterlab/windowed-notebook.test.ts:41:5 › should update window height on resize Error: expect(received).toBeLessThan(expected) Expected: < 1442 Received: 1442 57 | const heightAfterSplit = await getWindowHeight(panel); 58 | > 59 | expect(heightAfterSplit).toBeLessThan(fullHeight); | ^ 60 | 61 | // Resize the dock panel, increasing the notebook height/decreasing the launcher height. 62 | const resizeHandle = page.locator( at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/windowed-notebook.test.ts:59:28
[jupyterlab] › test/jupyterlab/windowed-notebook.test.ts:41:5 › should update window height on resize: galata/test/jupyterlab/windowed-notebook.test.ts#L59
2) [jupyterlab] › test/jupyterlab/windowed-notebook.test.ts:41:5 › should update window height on resize Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(received).toBeLessThan(expected) Expected: < 1442 Received: 1442 57 | const heightAfterSplit = await getWindowHeight(panel); 58 | > 59 | expect(heightAfterSplit).toBeLessThan(fullHeight); | ^ 60 | 61 | // Resize the dock panel, increasing the notebook height/decreasing the launcher height. 62 | const resizeHandle = page.locator( at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/windowed-notebook.test.ts:59:28
[jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script): galata/test/jupyterlab/debugger.test.ts#L1
3) [jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script) Test timeout of 60000ms exceeded.
[jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script): galata/src/helpers/debuggerpanel.ts#L129
3) [jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script) Error: page.waitForSelector: Target closed =========================== logs =========================== waiting for locator('.jp-DebuggerBreakpoints').locator('.jp-DebuggerBreakpoint') to be visible ============================================================ at src/helpers/debuggerpanel.ts:129 127 | */ 128 | async waitForBreakPoints(): Promise<void> { > 129 | await this.page.waitForSelector( | ^ 130 | '.jp-DebuggerBreakpoints >> .jp-DebuggerBreakpoint' 131 | ); 132 | } at DebuggerHelper.waitForBreakPoints (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/debuggerpanel.ts:129:21) at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/debugger.test.ts:144:25
[jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script): galata/test/jupyterlab/debugger.test.ts#L1
3) [jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script) Pending operations: - page.waitForSelector at src/helpers/debuggerpanel.ts:129:21
[jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables: galata/test/jupyterlab/debugger.test.ts#L1
4) [jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables Test timeout of 60000ms exceeded.
[jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables: galata/src/helpers/debuggerpanel.ts#L113
4) [jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables Error: page.waitForSelector: Target closed =========================== logs =========================== waiting for locator('.jp-DebuggerCallstack-body').locator('.jp-DebuggerCallstackFrame') to be visible ============================================================ at src/helpers/debuggerpanel.ts:113 111 | */ 112 | async waitForCallStack(): Promise<void> { > 113 | await this.page.waitForSelector( | ^ 114 | '.jp-DebuggerCallstack-body >> .jp-DebuggerCallstackFrame' 115 | ); 116 | } at DebuggerHelper.waitForCallStack (/home/runner/work/jupyterlab/jupyterlab/galata/src/helpers/debuggerpanel.ts:113:21) at /home/runner/work/jupyterlab/jupyterlab/galata/test/jupyterlab/debugger.test.ts:215:25
[jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables: galata/test/jupyterlab/debugger.test.ts#L1
4) [jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables Pending operations: - page.waitForSelector at src/helpers/debuggerpanel.ts:113:21
Visual Regression Documentation (3.10.6)
The following actions uses node12 which is deprecated and will be forced to run on node16: ifaxity/wait-on-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Visual Regression Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: ifaxity/wait-on-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
🎭 Playwright Run Summary
3 flaky [documentation] › test/documentation/debugger.test.ts:276:7 › Debugger › Breakpoints panel ───── [documentation] › test/documentation/debugger.test.ts:306:7 › Debugger › Source panel ────────── [documentation] › test/documentation/general.test.ts:19:7 › General › Welcome ────────────────── 56 passed (12.4m)
🎭 Playwright Run Summary
2 failed [jupyterlab] › test/jupyterlab/notebook-run.test.ts:33:7 › Notebook Run › Run Notebook and capture cell outputs [jupyterlab] › test/jupyterlab/windowed-notebook.test.ts:41:5 › should update window height on resize 3 flaky [jupyterlab] › test/jupyterlab/debugger.test.ts:121:7 › Debugger Tests › Start debug session (Script) [jupyterlab] › test/jupyterlab/debugger.test.ts:200:7 › Debugger Variables › Copy to globals should work only for local variables [jupyterlab] › test/jupyterlab/debugger.test.ts:281:7 › Debugger Variables › Copy to clipboard ─ 3 skipped 349 passed (57.8m)

Artifacts

Produced during runtime
Name Size
jupyterlab-documentation-report Expired
3.61 MB
jupyterlab-documentation-test-assets Expired
1.95 MB
jupyterlab-galata-report Expired
15.5 MB
jupyterlab-galata-test-assets Expired
11.7 MB