Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix min versions #4

Closed
wants to merge 9 commits into from
Closed

Conversation

krassowski
Copy link
Owner

No description provided.

* Upgrade galata to lab 4.1

Fix lockfile

* Use `jp-button` instead of button

* Be more explicit with test checking for "user menu with 2 items"

(it is not!); because in lab 4.1 the DOM hierarchy changed (toolbar
is now using shadow DOM), instead select the things which are of
interest using precise selectors

* Update snapshots

* Update two more snapshots, switch serial assertions to soft

* Fix `Create a notebook` test
Copy link

github-actions bot commented Apr 2, 2024

Binder 👈 Launch a Binder on branch krassowski/jupyter_collaboration/try-to-fix-min-versions

@krassowski krassowski added the documentation Improvements or additions to documentation label Apr 2, 2024
@krassowski krassowski force-pushed the try-to-fix-min-versions branch 2 times, most recently from 495ddc1 to c1b0153 Compare April 2, 2024 10:53
@krassowski krassowski force-pushed the try-to-fix-min-versions branch from c1b0153 to d8e33f7 Compare April 2, 2024 11:04
@krassowski krassowski closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant