Workaround test failure

tests/test_documents.py

@@ -40,7 +40,16 @@ async def test_dirty(
                 assert not jupyter_ydoc.dirty
 
 
+async def cleanup(jp_serverapp):
+    # workaround for a shutdown issue of aiosqlite, see
+    # https://github.com/jupyterlab/jupyter-collaboration/issues/252
+    await jp_serverapp.web_app.settings["jupyter_collaboration"].stop_extension()
+    # workaround `jupyter_server_fileid` manager accessing database on GC
+    del jp_serverapp.web_app.settings["file_id_manager"]
+
+
 async def test_room_concurrent_initialization(
+    jp_serverapp,
     rtc_create_file,
     rtc_connect_doc_client,
 ):
@@ -60,8 +69,11 @@ async def connect(file_format, file_type, file_path):
     t1 = time()
     assert t1 - t0 < 0.5
 
+    await cleanup(jp_serverapp)
+
 
 async def test_room_sequential_opening(
+    jp_serverapp,
     rtc_create_file,
     rtc_connect_doc_client,
 ):
@@ -81,3 +93,5 @@ async def connect(file_format, file_type, file_path):
     assert dt < 1
     dt = await connect(file_format, file_type, file_path)
     assert dt < 1
+
+    await cleanup(jp_serverapp)

ui-tests/package.json

@@ -9,8 +9,8 @@
     "test:update": "npx playwright test --update-snapshots"
   },
   "devDependencies": {
-    "@jupyterlab/galata": "^5.0.5",
-    "@jupyterlab/services": "^7.0.5",
+    "@jupyterlab/galata": "^5.1.5",
+    "@jupyterlab/services": "^7.1.5",
     "@playwright/test": "^1.35.0"
   },
   "resolutions": {

ui-tests/tests/notebook.spec.ts

@@ -109,7 +109,7 @@ test.describe('Initialization', () => {
     await guestPage.notebook.open(pathUntitled);
 
     const nbPanel = await page.notebook.getNotebookInPanel();
-    expect(await nbPanel?.screenshot()).toMatchSnapshot(
+    expect.soft(await nbPanel?.screenshot()).toMatchSnapshot(
       'initialization-create-notebook-host.png'
     );
 
@@ -131,9 +131,10 @@ test.describe('Initialization', () => {
 
     await guestPage.filebrowser.refresh();
     await guestPage.notebook.open(exampleNotebook);
+    await guestPage.notebook.activate(exampleNotebook);
 
     const nbPanel = await page.notebook.getNotebookInPanel();
-    expect(await nbPanel?.screenshot()).toMatchSnapshot(
+    expect.soft(await nbPanel?.screenshot()).toMatchSnapshot(
       'initialization-open-notebook-host.png'
     );
 

ui-tests/tests/user-menu.spec.ts

@@ -11,19 +11,21 @@ test.use( {
 });
 
 const openDialog = async (page: IJupyterLabPageFixture): Promise<Locator> => {
-  const sharedLinkButton = page.locator('button[data-command="collaboration:shared-link"]');
+  const sharedLinkButton = page.locator('jp-button[data-command="collaboration:shared-link"]');
   await sharedLinkButton.click();
   await expect(page.locator('.jp-Dialog')).toBeVisible();
   return page.locator('.jp-Dialog').first();
 };
 
-test('the top bar should contain the user menu with 2 items', async ({ page }) => {
-  const topBarItems = page.locator('#jp-top-bar > :not(.jp-Toolbar-spacer)');
-  await expect(topBarItems).toHaveCount(2);
+test('the top bar should contain one user menu and one share button', async ({ page }) => {
+  const shareButton = page.locator('#jp-top-bar jp-button[data-command="collaboration:shared-link"]');
+  await expect(shareButton).toHaveCount(1);
+  const userMenu = page.locator('#jp-top-bar .jp-MenuBar-anonymousIcon');
+  await expect(userMenu).toHaveCount(1);
 });
 
 test('should open dialog when clicking on the shared link button', async ({ page }) => {
-  const sharedLinkButton = page.locator('button[data-command="collaboration:shared-link"]');
+  const sharedLinkButton = page.locator('jp-button[data-command="collaboration:shared-link"]');
 
   expect(await sharedLinkButton.screenshot()).toMatchSnapshot(
     'shared-link-icon.png'