forked from jupyterlab/jupyter-ai
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move methods generating completion replies to provider #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
completion-generation-in-provider
branch
3 times, most recently
from
April 5, 2024 12:18
a614369
to
30a5792
Compare
…jupyterlab#712) * Update directory.py to add new file formats 1. Added single file functionality 2. Added HTML files 3. Added PDF files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dependencies Added pypdf==4.1.0, required for handling pdf files in /learn * Update directory.py to add new file formats 1. Added single file functionality 2. Added HTML files 3. Added PDF files * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update dependencies Added pypdf==4.1.0, required for handling pdf files in /learn * Amended directory.py Made changes for 1. matching all file extensions in lower case, to ensure no case sensitivity 2. Streamlined the PDF loader to remove a loop over pages, using join and list comprehension. * Update directory.py * Update directory.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
krassowski
force-pushed
the
completion-generation-in-provider
branch
from
April 10, 2024 19:27
a50f81a
to
45e2e56
Compare
… `/learn` (jupyterlab#733) * Handle single files, pdfs, errors (1) Enables handling single files, not just directories. (2) Learns PDFs with langchain's PyPDFLoader. (3) Gives a clean error w/o traceback when the file type that is being handled needs addtional packages. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * error handling for missing packages in learn.py Removed the extra attribute and additional response comments based on feedback from Piyush Jain and Andrii Ieroshenko * Amend error message for failure in learn.py Made the error message more generic as there are many different failure types. * Fixed build error. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <[email protected]>
…#735) * catch embedding model validation errors on extension init * pre-commit
krassowski
force-pushed
the
completion-generation-in-provider
branch
2 times, most recently
from
April 22, 2024 22:29
7357dec
to
c16bb54
Compare
…lab#726) * Remove closing markdown identifiers (jupyterlab#686) * Remove whitespace after closing markdown identifier * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Add an example completion provider Adjust name of variable to reflect new implementation
krassowski
force-pushed
the
completion-generation-in-provider
branch
from
April 22, 2024 23:06
c16bb54
to
4dcf885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.