-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker demo support #81
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome pull request Ben, thanks a lot for your contribution! I only had two minor comments ...
README.md
Outdated
@@ -236,7 +236,7 @@ print(f'PSNR = {psnr.numpy():3f}') | |||
trainer.model.save_weights('weights/wdsr-b-32-x4/weights.h5') | |||
``` | |||
|
|||
## SRGAN | |||
### SRGAN | |||
|
|||
### Generator pre-training |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start with ####
then? Also next section ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't what? SRGAN? Is it a subset of WDSR (above it) or Pre-trained weights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sections Generator pre-training
and Generator fine-tuning (GAN)
are subsections of SRGAN
, so when you increase the level of SRGAN
from ##
to ###
the levels of these subsections should be increased from ###
to ####
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I follow now! Updated: eacf877
Added support for trying out super-resolution with Docker.
Also added nvidia-docker support.