-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new metric helpers for counters and gauges #80
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 86.39% 87.52% +1.12%
==========================================
Files 6 6
Lines 522 569 +47
==========================================
+ Hits 451 498 +47
Misses 71 71 ☔ View full report in Codecov by Sentry. |
7ca739a
to
25c1346
Compare
|
||
### `$logger.metricGauge(<event>, <payload>);` | ||
|
||
Queues a gauge metric, helper wrapping `logger.metric` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is gauge a standard term here because I think this could use a bit more detail (I can kind of intuit what it means but it's not obvious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is, that's what its called in the OpenTelemetry library: https://opentelemetry.io/docs/specs/otel/metrics/api/#gauge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🇮🇹
|
||
### Deprecated - `$logger.metric(<event>, <payload>);` | ||
|
||
Queues a metric. We suggest using the `metricCount` or `metricGauge` interface for better type safety and clearer intention in your code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
No description provided.