Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NotFound exception message to include namespace #479

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

jacobtomlinson
Copy link
Member

While investigating dask/dask-kubernetes#903 it felt useful to know which namespace kr8s is looking in for a resource, but the NotFound exception doesn't show this. This PR improves the error message to include the namespace.

@github-actions github-actions bot added the kr8s label Aug 23, 2024
@jacobtomlinson jacobtomlinson added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 23, 2024
@jacobtomlinson jacobtomlinson changed the title Improve exception message to include namespace Improve NotFound exception message to include namespace Aug 23, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.08%. Comparing base (87063fc) to head (4c63e24).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_objects.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   94.61%   95.08%   +0.46%     
==========================================
  Files          29       30       +1     
  Lines        3141     3889     +748     
==========================================
+ Hits         2972     3698     +726     
- Misses        169      191      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jacobtomlinson jacobtomlinson merged commit 5b8e71c into kr8s-org:main Aug 23, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the notfound-ns branch August 23, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kr8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant