Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more informative error messages for merging sample metadata. The old version worked correctly but didn't point to which sample IDs were off. It also had a slightly weird behavior where you could add extra rows to the metadata table which would be silently dropped when we reindex on the genotype sample names. Now it checks that the metadata and genotypes sample vectors are the same length and that all genotype IDs are in the table. Any mismatches or duplicates are printed to screen.
Adding a duplicate row to sample_data now prints:
Changing one of the sample_data IDs prints:
and deleting a row in sample_data prints: