Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to msgspec for kw_only=True #2162

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

indrat
Copy link
Contributor

@indrat indrat commented Nov 11, 2024

Adds support to the msgspec output for kw_only=True similar to #2102

Removes default IMPORT_MSGSPEC_STRUCT from DEFAULT_IMPORTS since it's not required.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (957ce04) to head (bc21f6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4276      4279    +3     
  Branches       986       987    +1     
=========================================
+ Hits          4276      4279    +3     
Flag Coverage Δ
unittests 99.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #2162 will not alter performance

Comparing indrat:msgspec-kw-only-support (bc21f6b) with main (957ce04)

Summary

✅ 30 untouched benchmarks

@koxudaxi koxudaxi merged commit 41a37e0 into koxudaxi:main Nov 23, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants