-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend parsing of Scientific Notation to JSON capabilites #1956
base: main
Are you sure you want to change the base?
Extend parsing of Scientific Notation to JSON capabilites #1956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 4285 4287 +2
Branches 987 987
=========================================
+ Hits 4285 4287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1956 will not alter performanceComparing Summary
|
@maximilian-tech |
Hi, I like your consideration towards older users by not breaking the current behavior. However, I am not sure how such a flag should be called: I really think, that this is a bug, as only now JSON is parsed correctly, and should be the new default behavior. However, I would be happy either way :) Thanks for this nice tool! |
Thank you for agreeing with our opinion.
I agree that this is the case in most cases, but the problem is that being right often gets someone in trouble 😅 |
Agreed. 👍 |
I just wanted to know what the next steps would be. I really would like to have it in the main branch. |
Solves Issues #1955 (comment) and #1952 (comment)
It boils down to
yaml
vs.json
floating point parsing. TheSafeLoader
ofyaml
has to be extended to allow for the same range offloat
notations likejson
.See here for more background.
I copied the SO-solution and it does work (for me)