Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of nullable array items #1648

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

tfausten
Copy link
Contributor

@tfausten tfausten commented Nov 1, 2023

This fixes an issue where array items are not generated as Optional, despite adding the nullable: true property: #1496
I'm not sure if this is the best way to fix it, but it works well for me.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e9b6edf) 100.00% compared to head (a91fc2f) 99.92%.
Report is 754 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1648      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           11       34      +23     
  Lines         1020     3772    +2752     
  Branches       201      889     +688     
===========================================
+ Hits          1020     3769    +2749     
- Misses           0        1       +1     
- Partials         0        2       +2     
Flag Coverage Δ
unittests 99.57% <99.51%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
datamodel_code_generator/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/__main__.py 100.00% <100.00%> (ø)
datamodel_code_generator/arguments.py 100.00% <100.00%> (ø)
datamodel_code_generator/format.py 100.00% <100.00%> (ø)
datamodel_code_generator/http.py 100.00% <100.00%> (ø)
datamodel_code_generator/imports.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/__init__.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/dataclass.py 100.00% <100.00%> (ø)
datamodel_code_generator/model/enum.py 100.00% <100.00%> (ø)
... and 24 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi koxudaxi merged commit a4dd6f3 into koxudaxi:master Nov 4, 2023
83 of 85 checks passed
jaro0149 added a commit to FRINXio/frinx-services-python-api that referenced this pull request Apr 8, 2024
- bumped version of the datamodel-codegen because of the bug:
koxudaxi/datamodel-code-generator#1648
Jozefiel pushed a commit to FRINXio/frinx-services-python-api that referenced this pull request Apr 8, 2024
* FR-144 Updated generated UniConfig models

- bumped version of the datamodel-codegen because of the bug:
koxudaxi/datamodel-code-generator#1648

* FR-144 Bumped datamodel-codegen and regenerated JSON schema models

* FR-144 Bumped version of packages

- json-schema >> 0.0.2
- uniconfig >> 1.1.0

* FR-144 Fix/ignore codespell issues

* FR-144 Fixed codespell issues

* FR-144 Removed unuseed entry from .codespellignore

* FR-144 Ignore ruff errors in generated createsubscription.py file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants