Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#539] Support GHC 9.0 in generated projects #556

Merged
merged 7 commits into from
Jan 11, 2022
Merged

[#539] Support GHC 9.0 in generated projects #556

merged 7 commits into from
Jan 11, 2022

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented Jan 11, 2022

Resolves #539

@vrom911 vrom911 requested a review from chshersh as a code owner January 11, 2022 18:01
@vrom911 vrom911 self-assigned this Jan 11, 2022
@vrom911 vrom911 added generated project Files, folder generation by the summoner ghc Add/remove GHC versions, options labels Jan 11, 2022
chshersh
chshersh approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing and huge work! 👏🏻
Only a few suggestions 🙂

summoner-cli/src/Summoner/GhcVer.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Project.hs Outdated Show resolved Hide resolved
@vrom911 vrom911 force-pushed the vrom911/539-Support-GHC-90-in-generated branch from 527a70f to 3c2a392 Compare January 11, 2022 19:20
@vrom911 vrom911 force-pushed the vrom911/539-Support-GHC-90-in-generated branch from 9a6ae70 to 877199f Compare January 11, 2022 19:37
@chshersh chshersh merged commit 0c03dd0 into main Jan 11, 2022
@chshersh chshersh deleted the vrom911/539-Support-GHC-90-in-generated branch January 11, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
generated project Files, folder generation by the summoner ghc Add/remove GHC versions, options
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GHC 9.0 in generated projects
2 participants
@vrom911 @chshersh