Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#286] Consistent type for 'readMaybe' and 'readEither' #296

Merged
merged 2 commits into from
May 14, 2020
Merged

[#286] Consistent type for 'readMaybe' and 'readEither' #296

merged 2 commits into from
May 14, 2020

Conversation

vrom911
Copy link
Member

@vrom911 vrom911 commented May 14, 2020

Resolves #286

@vrom911 vrom911 added the enhancement New feature or request label May 14, 2020
@vrom911 vrom911 requested a review from chshersh as a code owner May 14, 2020 16:24
@vrom911 vrom911 self-assigned this May 14, 2020
hint-man[bot]
hint-man bot approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

chshersh
chshersh approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Juicy changelog entry 🟠

CHANGELOG.md Outdated Show resolved Hide resolved
@vrom911 @chshersh
Update CHANGELOG.md
b097578 
Co-authored-by: Dmitrii Kovanikov <[email protected]>
@chshersh chshersh merged commit 7eb0ce0 into master May 14, 2020
@chshersh chshersh deleted the vrom911/286-Consistent-type-for-readMaybe-and branch May 14, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] approved these changes

@chshersh chshersh chshersh approved these changes

Assignees

@vrom911 vrom911

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent type for 'readMaybe' and 'readEither'
2 participants
@vrom911 @chshersh