Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#108]: Bump up github to 0.23 #119

Merged
merged 4 commits into from
Oct 8, 2019
Merged

[#108]: Bump up github to 0.23 #119

merged 4 commits into from
Oct 8, 2019

Conversation

bangn
Copy link
Collaborator

@bangn bangn commented Oct 4, 2019 •
edited
Loading

Looks like bump up github to 0.23 fix problem I have in #118 as well

@bangn bangn requested review from chshersh and vrom911 October 4, 2019 14:12
@bangn bangn mentioned this pull request Oct 4, 2019
Merged
@bangn bangn changed the title [#108]: Bump up github to 0.22 [#108]: Bump up github to 0.23 Oct 4, 2019
@bangn bangn self-assigned this Oct 4, 2019
@chshersh
Copy link
Contributor

chshersh commented Oct 4, 2019

@bangn Thanks for the update! However, this PR should be verified carefully. Last time we've upgraded to github-0.21, it didn't work because it has a bug. Upgrade to github-0.22 broke the UI of hit-on. I believe that github-0.23 still has this problem, as described in #108. So this PR can be merged after fixing this known problem and after @vrom911 and I carefully verify that everything works as expected.

@chshersh chshersh added GitHub GitHub API Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 4, 2019
@bangn
[#108]: Fix show issue number bug
ad47eb7 
It now show issue number correctly.

For example:

[#123] instead of [IssueNumber #123]
@bangn
Copy link
Collaborator Author

bangn commented Oct 6, 2019

@chshersh thank you for your information. The bug described in #108 has been fixed by ad47eb7. However, Im not so sure if it will break anything.

Is there anyway we can automate the test process?

@chshersh
Copy link
Contributor

chshersh commented Oct 6, 2019

@bangn There's in an issue on how to test hit-on automatically, you can share your thoughts there:

Regarding this PR: I checked it locally on different commands, it seems to work and nothing breaks so far. So I would say I approve but I won't do it via GitHub UI yet to not merge it accidentally. We need some more time to check everything carefully 🙂

@vrom911
Copy link
Member

vrom911 commented Oct 7, 2019

Sorry for the delay in the review. Give me some more time to test it locally as well...
Thanks for your work, @bangn ! Really appreciate that 👏

vrom911
vrom911 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work nice for me! Thanks a lot, @bangn

@vrom911 vrom911 merged commit ba0e52d into master Oct 8, 2019
@vrom911 vrom911 deleted the bangn/108-Bump-up-to-github-0.22 branch October 8, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

@chshersh chshersh Awaiting requested review from chshersh

Assignees

@bangn bangn

Labels
GitHub GitHub API Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bangn @chshersh @vrom911