Use stricter column subsetting in multimed()
#58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kosukeimai. I'm using this package for a project and found that
multimed()
fails uninformatively in some cases. This is tied to the way that subsets are obtained from thedata
argument. This is the same issue as in #42.This PR adjusts the column subsets for
data
and its subsets to use the stricterdata[[column_name]]
format over the matrix-styledata[, column_name]
which works fordata.frame
objects but not thetibble
class extensions. (For context: Any data produced viareadr
,readxl
,vroom
, etc. will betibble
s. The error is a result of the stricter design choice fortibble
s and is explained in Wickham's Adavanced R)