Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stricter column subsetting in multimed() #58

Merged
merged 1 commit into from
May 17, 2023
Merged

Use stricter column subsetting in multimed() #58

merged 1 commit into from
May 17, 2023

Conversation

christopherkenny
Copy link
Contributor

Hi @kosukeimai. I'm using this package for a project and found that multimed() fails uninformatively in some cases. This is tied to the way that subsets are obtained from the data argument. This is the same issue as in #42.

This PR adjusts the column subsets for data and its subsets to use the stricter data[[column_name]] format over the matrix-style data[, column_name] which works for data.frame objects but not the tibble class extensions. (For context: Any data produced via readr, readxl, vroom, etc. will be tibbles. The error is a result of the stricter design choice for tibbles and is explained in Wickham's Adavanced R)

@kosukeimai
Copy link
Owner

Thanks @christopherkenny!

@kosukeimai kosukeimai merged commit a9a5c7b into kosukeimai:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants