Fix for missing symbol errors #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was getting errors ```
Undefined symbols for architecture x86_64:
"_luaL_checklstring", referenced from:
_lua_notify in lua.o
_lua_notify_with_pid in lua.o
"_luaL_checkversion_", referenced from:
_luaopen_lua_libnotify in lua.o
"_luaL_setfuncs", referenced from:
_luaopen_lua_libnotify in lua.o
"_lua_createtable", referenced from:
_luaopen_lua_libnotify in lua.o```
This fixed them. Tested on macos and linux
|
Again, can't reproduce. However, I guess it could depend on the environment and the Lua installation, so could you please clarify those? Also, please note that for C++ tests you don't need that target at all, and could build the static library only using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was getting errors
Undefined symbols for architecture x86_64: "_luaL_checklstring", referenced from: _lua_notify in lua.o _lua_notify_with_pid in lua.o "_luaL_checkversion_", referenced from: _luaopen_lua_libnotify in lua.o "_luaL_setfuncs", referenced from: _luaopen_lua_libnotify in lua.o "_lua_createtable", referenced from: _luaopen_lua_libnotify in lua.oThis fixed them. Tested on macos and linux