Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guild update not running on on_ready registered #45

Merged
merged 5 commits into from
Jul 21, 2024
Merged

fix: guild update not running on on_ready registered #45

merged 5 commits into from
Jul 21, 2024

Conversation

eunwoo1104
Copy link
Member

  • DiscordpyKoreanbots에서 run_task=True일 때 on_ready 이벤트가 새로 등록되는 경우 서버수 업데이트가 이루어지지 않는 문제를 해결했습니다.

@eunwoo1104 eunwoo1104 added the bug Something isn't working label Jul 21, 2024
@eunwoo1104 eunwoo1104 self-assigned this Jul 21, 2024
@eunwoo1104 eunwoo1104 requested a review from a team as a code owner July 21, 2024 13:35
@eunwoo1104 eunwoo1104 merged commit bcd2eab into master Jul 21, 2024
4 checks passed
@eunwoo1104 eunwoo1104 deleted the fix/on_ready branch July 21, 2024 13:46
@SaidBySolo
Copy link
Contributor

SaidBySolo commented Jul 21, 2024 via email •
edited
Loading

@star0202 star0202 mentioned this pull request Jul 22, 2024
Closed
@eunwoo1104
Copy link
Member Author

koreanbots/typing.py에 coro가 있던걸로 기억나는데 중복선언 같은 느낌이 드네용

아.. 다음에 확인해보고 리팩토링 하겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@star0202 star0202 star0202 approved these changes

@skinmaker1345 skinmaker1345 skinmaker1345 approved these changes

Assignees

@eunwoo1104 eunwoo1104

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eunwoo1104 @SaidBySolo @skinmaker1345 @star0202