fix: 서버 수 업데이트 시 오류 핸들링 (#46)

* fix: handle error raised during guild count update * chore: reformat code * feat: attach exception on error
koreanbots · Sep 18, 2024 · 3cdef7d · 3cdef7d
1 parent bcd2eab
commit 3cdef7d
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 8 deletions.
diff --git a/koreanbots/http.py b/koreanbots/http.py
@@ -113,8 +113,12 @@ async def request(
             async with self.session.request(
                 method, KOREANBOTS_URL + endpoint, **kwargs
             ) as response:
-                remain_limit = response.headers["x-ratelimit-remaining"]
-                if int(remain_limit) == 0 or response.status == 429:
+                remain_limit = response.headers.get("x-ratelimit-remaining")
+                if (
+                    remain_limit is not None
+                    and int(remain_limit) == 0
+                    or response.status == 429
+                ):
                     reset_limit_timestamp = int(response.headers["x-ratelimit-reset"])
                     reset_limit = datetime.fromtimestamp(reset_limit_timestamp)
                     retry_after = reset_limit - datetime.now()

diff --git a/koreanbots/integrations/dico.py b/koreanbots/integrations/dico.py
@@ -93,7 +93,13 @@ async def tasks_send_guildcount(self) -> None:
             if self.include_shard_count:
                 if self.client.shard_count:
                     kwargs.update({"shards": self.client.shard_count})
-            log.info("Send")
-            await self.guildcount(int(self.client.application_id), **kwargs)
-            log.info("Complete i will sleep")
+            log.info("Initiating guild count update...")
+            try:
+                await self.guildcount(int(self.client.application_id), **kwargs)
+            except:
+                log.exception("Guild count update failed due to an error.")
+            else:
+                log.info(
+                    "Guild count updated successfully. Waiting 30 minutes for the next update."
+                )
             await sleep(1800)
diff --git a/koreanbots/integrations/discord.py b/koreanbots/integrations/discord.py
@@ -117,7 +117,13 @@ async def tasks_send_guildcount(self) -> None:
             if self.include_shard_count:
                 if self.client.shard_count:
                     kwargs.update({"shards": self.client.shard_count})
-            log.info("Send")
-            await self.guildcount(self.client.user.id, **kwargs)
-            log.info("Complete i will sleep")
+            log.info("Initiating guild count update...")
+            try:
+                await self.guildcount(int(self.client.user.id), **kwargs)
+            except:
+                log.exception("Guild count update failed due to an error.")
+            else:
+                log.info(
+                    "Guild count updated successfully. Waiting 30 minutes for the next update."
+                )
             await sleep(1800)