feat: allow no-callback getData and model.pull #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgwozdz
added
enhancement
minor
🦋 Changeset detectedLatest commit: 91f8123 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, provider development required a
getDatamethod that took acallbackfunction as its second (last) argument. This forced developers to manage responses and errors through the callback function. This PR allowsgetDatato be a simpleasyncfunction with a singlereqargument that returns GeoJSON. Errors can be directly thrown.Similarly, output-plugins have had to use the callback argument when invoking the
model.pullmethod. It can now be used as a promise, without the callback argument.Note that Koop is still fully compatible with providers and outputs that leverage the callback pattern.