Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zookeeper.properties template for 2.0.0-M1 #356

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Jan 11, 2024

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets Partial #360
License Apache 2.0

What's in this PR?

Update of the zookeeper.properties template, to match the one in 2.0.0-M1.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx
Copy link
Contributor Author

juldrixx commented Jan 11, 2024

I don't know if the change server.1=nifi has an impact. I tested but I have no error.

@juldrixx juldrixx requested review from erdrix and mh013370 January 11, 2024 13:09
@juldrixx juldrixx added this to the Release 2.0.0 milestone Jan 11, 2024
@mh013370
Copy link
Member

mh013370 commented Jan 11, 2024

I don't know if the change server.1=nifi has an impact. I tested but I have no error.

It's only used for embedded zookeeper, so I don't think we'd see it in Kubernetes. I think it's probably okay. Anyone using this would need to override it to include each nifi node name anyway, so i don't think there's a risk. This can be merged with no risk.

@juldrixx juldrixx requested a review from mh013370 January 11, 2024 15:10
@juldrixx
Copy link
Contributor Author

@mh013370 I made a change to not use the template if not needed can you recheck?

@mh013370
Copy link
Member

@mh013370 I made a change to not use the template if not needed can you recheck?

Should we just remove the zookeeper properties template here like we removed the logback template in #353 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants