-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(RHTAPWATCH-1066): Unit tests for getWorkspacesWithAccess #50
Conversation
07374da
to
185e40c
Compare
@Omeramsc, @avi-biton Please review the PR. |
185e40c
to
01b7f49
Compare
01b7f49
to
d5c3b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress, please add cleanup after the unit tests.
d5c3b34
to
9021d0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource managment between tests require fixing.
Also if my comments are not about typos/basic syntax, please comment on them with how you fixed them before resolving them (or wait for my resolution).
Add unit test for workspace-manager function getWorkspacesWithAccess Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1066 Signed-off-by: Homaja Marisetty <[email protected]>
9021d0d
to
551ca85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add unit test for workspace-manager function
getWorkspacesWithAccess
Jira-Url: https://issues.redhat.com/browse/RHTAPWATCH-1066