test(RHTAPWATCH-1067): Unit tests for getUserNamespaces

[Kousalya1998]

Add unit test for func getUserNamespaces

[Omeramsc]

Overall good progress, but I am not sure why a change in the function itself is required

[Kousalya1998]

Overall good progress, but I am not sure why a change in the function itself is required

I saw your comments on the PR thanks. The reason why I had to modify the main function was: take for eg to get specific user namespace test case- the test is expecting only one namespace (“test-tenant”) but is returning all three namespaces (test-tenant, test-tenant2, test-tenant3). I felt that the label selector is not working as expected and thats why I added filteredNamespaces func in the main.go.

[Kousalya1998]

@Omeramsc I tried the method that you suggested

I think you get all the namespaces because all of them have those labels. I t makes sense since we created them to be used in the functional tests, if they would not have those labels they won't pass.It means we don't need to change the function, as it works as it should. what we need to change is the namespaces we create. or rather - create a new namespace (either for this test specifically or for the whole beforesuite, see what works better), that doesn't have this label. then you can see it is not returned.

[Kousalya1998]

@Omeramsc I tried the method that you suggested

I think you get all the namespaces because all of them have those labels. I t makes sense since we created them to be used in the functional tests, if they would not have those labels they won't pass.It means we don't need to change the function, as it works as it should. what we need to change is the namespaces we create. or rather - create a new namespace (either for this test specifically or for the whole beforesuite, see what works better), that doesn't have this label. then you can see it is not returned.

PTAL again. test cases pass.

[hmariset]

lgtm

[Omeramsc]

It looks much better now; I added a few more comments

[Kousalya1998]

@Omeramsc PTAL. Three test cases fail out of the 4 because the function getUserNamespaces appears to be returning all user namespaces, regardless of the specific request. The same error I said in the beginning.

[Omeramsc]

@Omeramsc PTAL. Three test cases fail out of the 4 because the function getUserNamespaces appears to be returning all user namespaces, regardless of the specific request. The same error I said in the beginning.

1. The BeforeSuite is still applied to all tests. this is not desireable, I'll push a change seperating the unit tests from the functional tests.
2. Probably a result of the former point, but in all tests you never created a namespace. the namespaces from the BeforeSuite are configured to pass the functional tests, so the fact they always return is a given. you shouldn't use them, you should create your own in the beforeEach
3. the echo server however is not needed in the beforeEach
4. resetting variables is in the afterEach is not needed, you need to reset (=remove) the namespaces you create.

If you have any more questions about why we use the beforeEach and afterEach for those tests and resource management, please don't hesitate to ask me before applying more changes to the code.

[Kousalya1998]

This PR is blocked by RHTAPWATCH-1237 Reorganize workspace-manager test suites.

[Omeramsc]

Good catch, I'm glad to see it moving forward. added some small requests

[Omeramsc]

LGTM