chore(RHTAPATCH-1069): unit-tests for runAccessCheck #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omeramsc
force-pushed
the
RHTAPWATCH-1069
branch
2 times, most recently
from
3264d4a to
5f99716
Compare
Omeramsc
force-pushed
the
RHTAPWATCH-1069
branch
from
5f99716 to
e4ede16
Compare
yftacherzog
reviewed
Jul 17, 2024
Omeramsc
force-pushed
the
RHTAPWATCH-1069
branch
from
e4ede16 to
3290ac9
Compare
|
/retest |
1 similar comment
|
/retest |
Omeramsc
force-pushed
the
RHTAPWATCH-1069
branch
from
3290ac9 to
7912ce7
Compare
yftacherzog
reviewed
Jul 21, 2024
cmd/main_test.go
Outdated
| Expect(err).NotTo(HaveOccurred(), "Unexpected error testing RunAccessCheck") | ||
| }, | ||
| Entry( | ||
| "A user that has access to the resource should return true (user2 have permission to 'create' on test-tenant-1)", |
There was a problem hiding this comment.
Suggested change
| "A user that has access to the resource should return true (user2 have permission to 'create' on test-tenant-1)", | |
| "A user that has access to the resource should return true (user2 has permission to 'create' on test-tenant-1)", |
cmd/main_test.go
Outdated
| "create", | ||
| true), | ||
| Entry( | ||
| "A user that does not have any premissions on the namespace should return false (user1 don't have access to test-tenant-2)", |
There was a problem hiding this comment.
Suggested change
| "A user that does not have any premissions on the namespace should return false (user1 don't have access to test-tenant-2)", | |
| "A user that does not have any premissions on the namespace should return false (user1 doesn't have access to test-tenant-2)", |
cmd/main_test.go
Outdated
| "create", | ||
| false), | ||
| Entry( | ||
| "A user that does not have the permissions to perform the specific action on the namespace should return false (user1 don't have permission to 'patch' on test-tenant-1)", |
There was a problem hiding this comment.
Suggested change
| "A user that does not have the permissions to perform the specific action on the namespace should return false (user1 don't have permission to 'patch' on test-tenant-1)", | |
| "A user that does not have the permissions to perform the specific action on the namespace should return false (user1 doesn't have permission to 'patch' on test-tenant-1)", |
Add unit-tests to `runAccessCheck`. We decided to perform the tests using the same test suite we are using for the functional tests, using testenv. It is setting up a real environment for us, and we don't have to deal with ugly fakes when using the k8s authorization. Signed-off-by: Omer Turner <[email protected]>
Omeramsc
force-pushed
the
RHTAPWATCH-1069
branch
from
7912ce7 to
f5ff0fd
Compare
yftacherzog
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit-tests to
runAccessCheck.We decided to perform the tests using the same test suite
we are using for the functional tests, using testenv.
It is setting up a real environment for us, and we don't
have to deal with ugly fakes when using the k8s authorization.